Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and As…

…m snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform.

Fixes flutter/flutter#40114

Change-Id: If8d71e9c19c2e794d29f7ecbacb87457890a2fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116883
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

assembler.cc

@@ -30,31 +30,6 @@ DEFINE_FLAG(bool, use_far_branches, false, "Enable far branches for ARM.");
 
 namespace compiler {
 
-AssemblerBase::~AssemblerBase() {}
-
-intptr_t AssemblerBase::InsertAlignedRelocation(BSS::Relocation reloc) {
-  // We cannot put a relocation at the very start (it's not a valid
-  // instruction)!
-  ASSERT(CodeSize() != 0);
-
-  // Align to a target word boundary.
-  const intptr_t offset =
-      Utils::RoundUp(CodeSize(), compiler::target::kWordSize);
-
-  while (CodeSize() < offset) {
-    Breakpoint();
-  }
-  ASSERT(CodeSize() == offset);
-
-  AssemblerBuffer::EnsureCapacity ensured(&buffer_);
-  buffer_.Emit<compiler::target::word>(BSS::RelocationIndex(reloc) *
-                                       compiler::target::kWordSize);
-
-  ASSERT(CodeSize() == (offset + compiler::target::kWordSize));
-
-  return offset;
-}
-
 static uword NewContents(intptr_t capacity) {
   Zone* zone = Thread::Current()->zone();
   uword result = zone->AllocUnsafe(capacity);

assembler.h

@@ -305,7 +305,7 @@ class AssemblerBase : public StackResource {
         prologue_offset_(-1),
         has_single_entry_point_(true),
         object_pool_builder_(object_pool_builder) {}
-  virtual ~AssemblerBase();
+  virtual ~AssemblerBase() {}
 
   intptr_t CodeSize() const { return buffer_.Size(); }
 
@@ -320,10 +320,6 @@ class AssemblerBase : public StackResource {
   void Comment(const char* format, ...) PRINTF_ATTRIBUTE(2, 3);
   static bool EmittingComments();
 
-  virtual void Breakpoint() = 0;
-
-  intptr_t InsertAlignedRelocation(BSS::Relocation reloc);
-
   void Unimplemented(const char* message);
   void Untested(const char* message);
   void Unreachable(const char* message);

assembler_arm.h

@@ -392,7 +392,7 @@ class Assembler : public AssemblerBase {
 #endif  // TESTING || DEBUG
 
   // Debugging and bringup support.
-  void Breakpoint() override { bkpt(0); }
+  void Breakpoint() { bkpt(0); }
   void Stop(const char* message) override;
 
   static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);

assembler_arm64.h

@@ -485,7 +485,7 @@ class Assembler : public AssemblerBase {
   void set_use_far_branches(bool b) { use_far_branches_ = b; }
 
   // Debugging and bringup support.
-  void Breakpoint() override { brk(0); }
+  void Breakpoint() { brk(0); }
   void Stop(const char* message) override;
 
   static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);

assembler_dbc.h

@@ -43,7 +43,6 @@ class Assembler : public AssemblerBase {
   void MonomorphicCheckedEntryAOT() {}
 
   // Debugging and bringup support.
-  void Breakpoint() override { Stop("Breakpoint!"); }
   void Stop(const char* message) override;
 
   static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);

assembler_ia32.h

@@ -835,7 +835,7 @@ class Assembler : public AssemblerBase {
                         Register temp);
 
   // Debugging and bringup support.
-  void Breakpoint() override { int3(); }
+  void Breakpoint() { int3(); }
   void Stop(const char* message) override;
 
   static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);

assembler_x64.h

@@ -936,7 +936,7 @@ class Assembler : public AssemblerBase {
   void GenerateUnRelocatedPcRelativeCall(intptr_t offset_into_target = 0);
 
   // Debugging and bringup support.
-  void Breakpoint() override { int3(); }
+  void Breakpoint() { int3(); }
   void Stop(const char* message) override;
 
   static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);