Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont send report if err is nil #26

Merged
merged 2 commits into from
May 15, 2022
Merged

fix: dont send report if err is nil #26

merged 2 commits into from
May 15, 2022

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented May 15, 2022

fixes CaptureException called with nil error

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #26 (58df84c) into master (9ae3411) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   35.79%   35.79%           
=======================================
  Files          15       15           
  Lines         908      908           
=======================================
  Hits          325      325           
  Misses        524      524           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae3411...58df84c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 15, 2022

This pull request fixes 1 alert when merging 58df84c into 9ae3411 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@aldy505 aldy505 merged commit f923c60 into master May 15, 2022
@aldy505 aldy505 deleted the fix/nil-error branch June 4, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant