Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERLIS Export - subclass_check #337

Closed
sjib opened this issue Jul 26, 2024 · 3 comments
Closed

INTERLIS Export - subclass_check #337

sjib opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@sjib
Copy link
Contributor

sjib commented Jul 26, 2024

Describe the bug
When exporting data with INTERLIS and the _subclass_check throws and error, the export process is not stopped anymore and the ERROR only shows up in the depth of the tww protocol:

2024-07-26T10:29:03 teksi_wastewater.utils:ERROR: number of subclass elements of structure_part NOT CORRECT in schema tww_od: checksum = 1 (positive number means missing entries, negative means too many subclass entries)

20240726_subclass_check_missing_structure_part

To Reproduce
Exact steps to reproduce the behavior:

  1. Create additional data entry in superclass e.g. structure_part (that has no reference subclass entry)
    20240726_subclass_check_missing_add_extra_structure_part

  2. Click on 'INTERLIS export'

  3. Select export file and start export

  4. See valid export message

  5. Check for ERROR: number of subclass elements of in protocol tab 'tww'

  6. Find entry

Expected behavior
A clear and concise description of what you expected to happen.

When subclass_check throws an error, the export process should be canceled and a red error message should appear message bar.

Desktop (please complete the following information):

  • TWW version pre-release 2024.0
  • QGIS Version 3.34.8
  • OS windows 10

Additional context
Add any other context about the problem here.

@sjib sjib added the bug Something isn't working label Jul 26, 2024
@sjib
Copy link
Contributor Author

sjib commented Jul 26, 2024

ilivalidator does not find this error and skips the export of this extra dataset (ch080qwzEE001233) - but the user will not be aware of this because he/she gets a success message.

@sjib
Copy link
Contributor Author

sjib commented Jul 26, 2024

Adapt error handlinge here in _check_subclass_count:

@sjib
Copy link
Contributor Author

sjib commented Jul 26, 2024

@cymed Any quick idea how to improve this? How can we exit the export process in tww?

This is how it is implemented in qgep:
https://github.com/QGEP/qgepqwat2ili/blob/48c8a7fe15f55a26c8ba0c65eb43eee23573cb55/qgepqwat2ili/gui/__init__.py#L424

@sjib sjib added this to the TEKSI Wastewater 2024.0 milestone Jul 26, 2024
@sjib sjib self-assigned this Jul 26, 2024
@sjib sjib closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant