Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should not supply auth token in chains-config configMap in plaintext #1074

Open
PuneetPunamiya opened this issue Mar 14, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PuneetPunamiya
Copy link
Member

PuneetPunamiya commented Mar 14, 2024

Feature request

As of today vault token is supplied via the signers.kms.kmsref.auth.token field which is not very ideal as it stores the token in clear text

This can also be true for other tokens as well

@PuneetPunamiya PuneetPunamiya added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 14, 2024
@wlynch
Copy link
Member

wlynch commented Mar 14, 2024

Agreed. We should make this a secret ref (though for backwards compatibility probably needs to be a new field)

@concaf
Copy link
Contributor

concaf commented Apr 3, 2024

@lcarva did you propose signers.kms.auth.token-path as a fix for this issue?

@lcarva
Copy link
Contributor

lcarva commented Apr 3, 2024

@lcarva did you propose signers.kms.auth.token-path as a fix for this issue?

I believe @PuneetPunamiya did during one of the Chains WG meeting. There was unanimous agreement among the Chains maintainers IIRC.

@concaf
Copy link
Contributor

concaf commented Apr 3, 2024

ack, sounds good :) i agree with the solution and it solves similar issues as users are facing with MONGO_SERVER_URL rotation (like you said already 😛)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants