Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade setup-ko to its latest version #575

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

developer-guy
Copy link
Contributor

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Changes

I upgraded the setup-ko GitHub Action to the latest version because ko has been moving its organization recently.

https://github.com/imjasonh/setup-ko#github-action-to-install-and-setup-ko

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

e2e tests are now using the latest of the version of _setup-ko_ GitHub action because ko has been moving its organization recently.

/cc @imjasonh

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2022
@tekton-robot
Copy link

Hi @developer-guy. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wlynch
Copy link
Member

wlynch commented Sep 28, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2022
@wlynch
Copy link
Member

wlynch commented Sep 28, 2022

Integration test failure is likely not from this change, we've been seeing it in a few other PRs starting yesterday. Filed #577 to track.

@wlynch
Copy link
Member

wlynch commented Oct 12, 2022

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@wlynch
Copy link
Member

wlynch commented Oct 12, 2022

@developer-guy - you may need to rebase to pick up the integration test fixes.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@lcarva
Copy link
Contributor

lcarva commented Oct 13, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@tekton-robot tekton-robot merged commit 947756f into tektoncd:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants