Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Create TaskRun to full page UI #1792

Closed
AlanGreene opened this issue Oct 27, 2020 · 1 comment · Fixed by #1891
Closed

Move Create TaskRun to full page UI #1792

AlanGreene opened this issue Oct 27, 2020 · 1 comment · Fixed by #1891
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Oct 27, 2020

From #966 (showing Create PipelineRun as an example)

  1. Update "Create PipelineRun" UI. Move from modal window to full page for better user experience and consistency with the rest of the dashboard.

Expected behavior
694b9800-4112-11ea-8724-3f98d5a4b8d7
5fcc2b00-4126-11ea-8bdc-b0fb68961fb1

Actual behavior
53ee7003-440c-4efe-a1d7-cc6e10b25977

See Create PipelineResource as an example of how we've done this before: #1591

URL and path for routing are already defined:

It's important to ensure the page title is correctly updated once it's move to its own page, see for example:

document.title = getTitle({
page: intl.formatMessage({
id: 'dashboard.createPipelineResource.title',
defaultMessage: 'Create PipelineResource'
})
});

@AlanGreene
Copy link
Member Author

/kind cleanup
/kind design

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. labels Oct 27, 2020
@AlanGreene AlanGreene added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 28, 2020
@AlanGreene AlanGreene self-assigned this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants