Move Create PipelineResource to a URL addressable page #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
size/XXL
|
@AlanGreene: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AlanGreene
force-pushed
the
createpipelineresource_page
branch
from
09f7c34
to
34dbec9
Compare
tekton-robot
added
size/XL
tekton-robot
removed
the
do-not-merge/work-in-progress
AlanGreene
force-pushed
the
createpipelineresource_page
branch
from
34dbec9
to
9a3cbd8
Compare
AlanGreene
removed
the
needs-rebase
src/containers/CreatePipelineResource/CreatePipelineResource.js
Outdated
Show resolved
Hide resolved
Move the Create PipelineResource form to a full page instead of a modal. This follows the pattern we've already implemented for Create Secret. Update the page title.
AlanGreene
force-pushed
the
createpipelineresource_page
branch
from
9a3cbd8
to
1f068a4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
3 tasks
|
/retest |
|
/test pull-tekton-dashboard-integration-0-11-3-tests |
|
/retest |
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to point 5 of #966 (move create dialogs to full page experience)
Move the Create PipelineResource form to a full page instead
of a modal. This follows the pattern we've already implemented
for Create Secret.
Update the page title.
Depends on #1589Note: ignore whitespace for an easier review
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.