Misc. Front End Development Specs for Dashboard Designs

[kimholmes]

This issue should reside under the following Epic:
#965

• 1. Remove blue background Tracked in Dashboard UI Implementation for the Rail and Header Navigation  #803

  Expected behavior - no blue background
  

  Actual behavior
  

• 2. Filter pill appearing when linking to PLRs filtered by Pipeline

  Expected behavior
  The filter remains empty since the user never engaged with it.

  Actual behavior
  A search term gets added to the filter without the user's interaction.
  

• 3. Make tables consistent per design. Remove ellipse action menu and move actions into header per Carbon table component

  Expected behavior
  Actions are stored in the header and activated when a row is selected
  

  Actual behavior
  The table stores actions in an "actions ellipse" at the end of the rows instead of using the Carbon header that utilizes checkboxes and buttons.
  

  The Create buttons on the PipelineRuns and PipelineResources pages should also be moved to the Table header as on the Secrets page. Done

• 4. Update Filter design throughout

  Expected behavior
  
  

  Actual behavior
  

• 5. Update "Create PipelineRun" UI. Move from modal window to full page for better user experience and consistency with the rest of the dashboard.

  Expected behavior
  
  

  Actual behavior
  

[AlanGreene]

1. Should this wait for the rail or do we want to do something tactical in the short term? If we just remove the blue and leave the side nav as-is it looks incomplete and there's no separation between it and the content.
   

2. Adding/removing filters updates the URL so the user can always share/bookmark that URL to return to the filtered list they're currently viewing (selected namespace + label filters). It's important to keep this functionality.

   The connection between the URL and the filters also works in the opposite direction, which is what you're seeing here. When we link to a filtered view (e.g. from the Pipelines table), those filters are included in the URL. The label filter component reacts to the presence of the filters in the URL and displays the corresponding tags for consistency.

   If we remove this second piece of behaviour, a user would be presented with two slightly different views of the same data (one showing the filter tags, the other not), and it wouldn't be obvious that they're both actually filtered in the same way.

   As we discussed last week, does this need to be part of a bigger change? i.e. introducing the missing detail pages for Pipeline, Task, etc., and having a more explicit action on the Pipelines / Tasks lists to view a filtered list of runs for the selected item? This way it shouldn't be a surprise to the user that the filter is pre-populated when they land on the runs list.

3. For actions such as re-running a PipelineRun where a user is most likely to only select a single item are we OK with keeping an inline action on the row using an icon instead of the overflow menu or do we want to move all actions to the table batch actions in the header? https://carbondesignsystem.com/components/data-table/usage#inline-actions

[kimholmes]

@AlanGreene I think it's ok to wait for the rail before you remove that blue background. Need to get a status on the rail though. :-)

I understand what you mean about needing the URL with the filter. My concern is whether or not the user will actually even know that it's there. I'm afraid if we user tested this, the user wouldn't even be aware that this function exists. It's a bit "under the covers."

Yes, I think it's totally fine to put the re-run function on the table row for the PLRs. Since it's only one action, I think we should use a simple icon with a column header instead of hiding it in that action dropdown menu.

[AlanGreene]

For 3. we should also include moving the Create buttons to the table header instead of beside the filter as discussed at our last design office hours. Updated the description above.

[kimholmes]

Yes! The design for these pages are spec'ed out in the following issues:
#727
https://kimholmes.github.io/Exported-Specs/Secrets/Secrets_Main/

[kimholmes]

@AlanGreene @carlos-logro FYI - Just added the "Create PipelineRun" panel to this issue. The spec is to move it to a full page. Thanks.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

/remove-lifecycle rotten
/reopen

[tekton-robot]

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

Batch delete for PipelineRuns and TaskRuns will be added as part of #1752, this addresses part of item 3.

[AlanGreene]

Tracking 5. in #1791

[AlanGreene]

Similar issue for Create TaskRun since we didn't have that functionality when 5. was written: #1792

[AlanGreene]

Closing as the remaining items are already tracked in other issues linked above.

/close

[tekton-robot]

@AlanGreene: Closing this issue.

In response to this:

Closing as the remaining items are already tracked in other issues linked above.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.