Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of secrets created in dashboard #538

Closed
mtamboli opened this issue Sep 20, 2019 · 1 comment
Closed

Validation of secrets created in dashboard #538

mtamboli opened this issue Sep 20, 2019 · 1 comment

Comments

@mtamboli
Copy link

Expected Behavior

In Tekton Dashboard -> Creating secrets
It would be nice to have validation for the secrets entered. Currently, you can enter incorrect user/password or server URL and the secret is created successfully. It would be nice to have the option to validate them. It could also be a separate option after creation or at the time of submit.
Especially with the URL, it has happened that user had a typo in server URL which was hard to find https://githud.com instead of https://github.com. It will make things easier for debugging.

Actual Behavior

No validations seems to be happening

  1. I saw secrets being created with incorrect user/password/URL
    image

  2. In one instance, when creating docker secret with below values: just got this error which is not useful at all. It did not have option to correct anything and all the entered information was lost.
    image

image

Steps to Reproduce the Problem

  1. Create Secrets from Tekton Dashboard

Additional Info

@AlanGreene
Copy link
Member

For 1, I don't think the dashboard should be responsible for validating that the credentials provided are correct. We should however ensure that any useful logs or other indicators are correctly surfaced to the user in case of tasks depending on these secrets failing. Some of this will be covered by #572 and related issues.

For 2, #611 should address this by ensuring the error is displayed in the modal, allowing the user to take corrective action without losing the input data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants