Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineRun init errors should be displayed in the Tekton Dashboard #572

Closed
CarolynMabbott opened this issue Sep 26, 2019 · 13 comments · Fixed by #1814
Closed

PipelineRun init errors should be displayed in the Tekton Dashboard #572

CarolynMabbott opened this issue Sep 26, 2019 · 13 comments · Fixed by #1814
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CarolynMabbott
Copy link
Member

Expected Behavior

When a pipelinerun fails it should update the pipelinerun properly

Actual Behavior

The pipelinerun fails and is stuck failing without logs as the pod is stuck in initError state
There are no logs to explain why it has failed

Additional Info

Not just applicable to this example, screenshot below

Screenshot 2019-09-26 at 17 22 54

@a-roberts a-roberts changed the title PipelineRun Status should be accurately updated in pipelinerun PipelineRun init errors should be displayed in the Tekton Dashboard Sep 26, 2019
@a-roberts
Copy link
Member

I'm wondering if this can be used to remedy #560

@mnuttall
Copy link
Contributor

I'm not sure what's possible here - use this to investigate whether initialisation errors can be reliably detected, and meaningful messages extracted.

@AlanGreene
Copy link
Member

We added code to handle some init error cases for #200
This may need to be updated to include additional classes of error that aren't currently handled.

@EnriqueL8
Copy link

EnriqueL8 commented Dec 9, 2019

👍 on this feature

@AlanGreene AlanGreene added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2019
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

We should do another review to make sure all cases are covered, and only then close this.

/remove-lifecycle rotten
/reopen

@tekton-robot tekton-robot reopened this Aug 13, 2020
@tekton-robot
Copy link
Contributor

@AlanGreene: Reopened this issue.

In response to this:

We should do another review to make sure all cases are covered, and only then close this.

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@AlanGreene
Copy link
Member

I think it would be a good idea to consider this along with #972 and #1445 to ensure we provide a good experience and don't introduce too many different mechanisms for accessing errors / logs.

@AlanGreene
Copy link
Member

AlanGreene commented Nov 9, 2020

Since Dashboard v0.7 we now display additional information on the TaskRun status (by selecting the TaskRun in the tree) which will include relevant details for many of these cases.

Once #1814 is merged, init step container details will always be displayed, not just in case of error as they are today. This will address the last remaining problem covered by this issue.

@AlanGreene
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
6 participants