Update PipelineResources page to use Table batch actions #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
tekton-robot
removed
the
do-not-merge/work-in-progress
| "dashboard.pipelineResource.errorLoading": "Error loading PipelineResource", | ||
| "dashboard.pipelineResource.failed": "Cannot load PipelineResource", | ||
| "dashboard.pipelineResource.failedSubtitle": "PipelineResource {pipelineResourceName} not found", | ||
| "dashboard.pipelineResource.fieldName": "Field Name", | ||
| "dashboard.pipelineResource.secretKey": "Secret Key", | ||
| "dashboard.pipelineResource.secretName": "Secret Name", | ||
| "dashboard.pipelineResources.createSuccess": "Successfully created PipelineResource", | ||
| "dashboard.pipelineResources.deleteConfirm": "Are you sure you want to delete these PipelineResources?", |
There was a problem hiding this comment.
Are the pipeline resources listed in the message ?
There was a problem hiding this comment.
Yes similar to the experience for Secrets, we display an unordered list of the PipelineResource names below this prompt.
tekton-robot
added
size/XXL
Move the delete functionality for the PipelineResources page to Carbon DataTable batch action which appears in the table header instead of using overflow menus on each individual row.
AlanGreene
force-pushed
the
pipelineresources_batchdelete
branch
from
14a877c
to
6e20dea
Compare
tekton-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move the delete functionality for the PipelineResources page
to Carbon DataTable batch action which appears in the table
header instead of using overflow menus on each individual row.
#969
#966 (item 3)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.