Display placeholders for pipeline tasks that haven't begun executing yet #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
tekton-robot
removed
the
do-not-merge/work-in-progress
steveodonovan
approved these changes
Dec 11, 2020
tekton-robot
added
lgtm
On the PipelineRun details page, display placeholders for pipeline tasks that don't yet have a corresponding TaskRun. Fill in spec details where available so the user can still view the definition. Once the pipeline task begins executing the placeholder will be replaced with the real TaskRun and corresponding details. In the case of Conditions, we make a best effort to display placeholders for the TaskRuns generated to evaluate them. Once they execute we will display the correct TaskRun details, however before this is available the placeholder may be incomplete and may become unselected as the PipelineRun updates. This is due to a lack of required runtime information to produce a consistent link between the resources. Since Conditions are deprecated, we're not planning to invest further effort in improving this. This update also changes the ordering of TaskRun in the TaskTree component. Instead of sorting by start time of the first step in each TaskRun, they're now sorted in order of definition in the Pipeline. A nice (subj.) side effect of this is that retries for a given TaskRun will be displayed immediately following the corresponding TaskRun rather than interspersed among other TaskRuns in an often unpredictable order. Future changes to the display of retries will further improve this grouping.
AlanGreene
force-pushed
the
tasktree_complete
branch
from
0cb9c14
to
ece0880
Compare
|
@steveodonovan rebased and resolved the merge conflict, good to go again. Thanks
Technically yes but it was never documented and defaulted to disabled anyway so 🤷 As far as I know the Dashboard itself was the only user of that prop. Hopefully anyone who poked around in the code, found it, and was using it, will prefer the new 'more correct' behaviour 😅 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #1263
Resolves #932
On the PipelineRun details page, display placeholders for pipeline tasks
that don't yet have a corresponding TaskRun. Fill in spec details where
available so the user can still view the definition.
Once the pipeline task begins executing the placeholder will be replaced
with the real TaskRun and corresponding details.
In the case of Conditions, we make a best effort to display placeholders
for the TaskRuns generated to evaluate them. Once they execute we will
display the correct TaskRun details, however before this is available
the placeholder may be incomplete and may become unselected as the
PipelineRun updates. This is due to a lack of required runtime information
to produce a consistent link between the resources. Since Conditions are
deprecated, we're not planning to invest further effort in improving this.
This update also changes the ordering of TaskRun in the TaskTree component.
Instead of sorting by start time of the first step in each TaskRun, they're
now sorted in order of definition in the Pipeline.
A nice (subj.) side effect of this is that retries for a given TaskRun
will be displayed immediately following the corresponding TaskRun rather
than interspersed among other TaskRuns in an often unpredictable order.
Future changes to the display of retries will further improve this grouping.
Before:
After:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.