-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to create PipelineRun from YAML [codemirror] #2575
Conversation
Hi @marniks7. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
/assign @AlanGreene |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @marniks7, thanks for switching to the new editor. I've left a few comments, mostly related to naming / consistency, nothing too major.
I've also left a comment about the CSP value and a pointer to where it needs to be configured for the production build.
Let me know if you have any questions.
663b154
to
f771ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bit of a styling issue in dark mode, the colour contrast for some of the YAML tokens is very low rendering them practically invisible.
We should load a dark theme to handle this. In future we will likely roll our own theme to match the rest of the app but for now one of the defaults will be sufficient.
Otherwise this looks great 👍 Thanks for all your hard work so far and quick turnaround on feedback, it's very much appreciated.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changed to theme=dark. Tested in both light and dark tekton themes - looks good. |
Thanks @marniks7 |
Changes
Add ability to create PipelineRun from YAML
YAML Mode
button onCreate Pipeline Page
YAML Mode
#/pipelineruns/create?mode=yaml
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes