Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #2647

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Update dependencies #2647

merged 2 commits into from
Jan 4, 2023

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Jan 3, 2023 •
edited

Changes

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Update dependencies.
Update e2e to be more resilient to timing issues navigating from Create PipelineRun to the PipelineRuns page.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2023
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi January 3, 2023 14:46
@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2023
@AlanGreene
Update e2e to remove unnecessary use of parent()
bc82f37 
Target the `a` element specifically to avoid potential issue where
Cypress finds a `span` containing the target text and clicks it
(which does nothing, matching the behaviour seen in failure videos)
instead of waiting for it to become a link.
@AlanGreene AlanGreene mentioned this pull request Jan 3, 2023
Closed
briangleeson
briangleeson approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2023
@tekton-robot tekton-robot merged commit ef5210b into tektoncd:main Jan 4, 2023
@AlanGreene AlanGreene deleted the deps branch January 4, 2023 10:22
@AlanGreene AlanGreene mentioned this pull request Jan 4, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlanGreene @tekton-robot @briangleeson