Downgrade react-router-dom-v5-compat due to breaking change
#2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`react-router-dom-v5-compat@6.5.0` introduces a breaking change that affects behaviour of `generatePath`. The presence of the `?` in the URL now triggers the new 'optional route segments' behaviour, and the `?` is given special meaning. This results in broken URLs as named placeholders in the query string are no longer replaced, e.g. `:pipelineName` is output as-is in the URL instead of being replaced with the value of the provided `pipelineName` param. Updating the Dashboard to support this new behaviour will take some time as it's core to how the routes and URLs used for filtering are implemented. Rolling back the update for now to unblock other changes.
tekton-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
This was referenced Feb 28, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to #2647
react-router-dom-v5-compat@6.5.0introduces a breaking change that affects behaviour ofgeneratePath. The presence of the?in the URL now triggers the new 'optional route segments' behaviour, and the?is given special meaning. This results in broken URLs as named placeholders in the query string are no longer replaced, e.g.:pipelineNameis output as-is in the URL instead of being replaced with the value of the providedpipelineNameparam.Updating the Dashboard to support this new behaviour will take some time as it's core to how the routes and URLs used for filtering are implemented. Rolling back the update for now to unblock other changes.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes