Initial pre-submit script… #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/hold
tekton-robot
added
the
size/L
matzew
reviewed
Apr 24, 2019
vdemeester
force-pushed
the
initial-presumit-script
branch
6 times, most recently
from
8957414
to
d54a035
Compare
… partly imported from `tektoncd/pipeline`. This is a really early draft but should allow better test coverage on dashboard to start. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
initial-presumit-script
branch
from
d54a035
to
5f2859e
Compare
|
Race condition issue : #73 |
vdemeester
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
10 tasks
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
1 task
|
oups sorry @abayer =) /assign @a-roberts |
|
Output from this looks great and any improvements can be made after - thank you so much @vdemeester for working on this! /lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm (poking Prow) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… partly imported from
tektoncd/pipeline/hold
Signed-off-by: Vincent Demeester vdemeest@redhat.com