Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Prow configuration for tektoncd/dashboard repository #5

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

vdemeester
Copy link
Member

Changes

This adds just one check that will run ./test/presubmit-test.sh --tests for now. We can add more later one πŸ˜‰

cc @a-roberts

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

This adds just one check that will run `./test/presubmit-test.sh
--tests` for now. We can add more later one πŸ˜‰

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@vdemeester
Copy link
Member Author

@bobcatfish it's deployed (see tektoncd/dashboard#72)

@abayer
Copy link
Contributor

abayer commented Apr 24, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@tekton-robot tekton-robot merged commit ddbf503 into tektoncd:master Apr 24, 2019
@vdemeester vdemeester deleted the initial-prow-for-dashboard branch April 24, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants