Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden scope of supported pipelines #39

Closed
mnuttall opened this issue Jun 4, 2019 · 1 comment
Closed

Broaden scope of supported pipelines #39

mnuttall opened this issue Jun 4, 2019 · 1 comment
Labels

Comments

@mnuttall
Copy link
Contributor

mnuttall commented Jun 4, 2019

See tektoncd/dashboard#47 - this issue and dashboard 47 are very closely linked, and are probably duplicates.

Webhooks creation and manual pipeline run initiation are much too hardcoded for a small subset of test pipelines. We need a much more flexible design in both areas. Ideally:

apiVersion: tekton.dev/v1alpha1
kind: TemplateBinding
metadata:
  name: simple-pipeline-push
  namespace: default
spec:
  templateRef:
    name: simple-pipeline-template
  serviceAccount: default
  event:
    class: cloudevent
    type: com.github.push
  params:
    - name: gitrevision
      value: ${event.head_commit.id}
    - name: gitrepositoryurl
      value: ${event.repository.url}
    - name: dockerusername
      value: ncskier
    - name: dockerappname
      value: helloworldapp

This TemplateBinding format gives us a way of defining the parameters that we should attempt to automatically fill in - gitrevision, gitrepositoryurl, and those params that the user must provide - docker username, application name.

We should make every effort to move the Tekton EventBinding integration work forward as a pre-req to this work.

@mnuttall
Copy link
Contributor Author

Closing this as a duplicate of #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant