Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers should use npm ci when installing the webhook extension from source #85

Closed
a-roberts opened this issue Jun 21, 2019 · 3 comments
Assignees
Labels

Comments

@a-roberts
Copy link
Member

Expected Behavior

package-lock.json should be adhered to

Actual Behavior

We suggest npm installing. We should suggest Node.js 10.x I believe and npm ci instead so our package-lock.json is taken into account.

@dibbles noticed bold font styling and a scrollbar on the delete dialog for the extension when using Node 12 with a newly generated package-lock.json as a result of npm installing - by using npm ci with both the dashboard and extension, we're good.

See tektoncd/dashboard#277 for the related dashboard issue.

@a-roberts a-roberts changed the title Advocate for reproducible builds on installing the extension from source Advocate for reproducible builds on installing the webhook extension from source Jun 21, 2019
@mnuttall mnuttall changed the title Advocate for reproducible builds on installing the webhook extension from source Developers should use npm ci when installing the webhook extension from source Jul 1, 2019
@Megan-Wright
Copy link
Member

/assign

@Megan-Wright
Copy link
Member

/close

@tekton-robot
Copy link

@Megan-Wright: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants