Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers should use npm ci when installing the dashboard from source #277

Closed
a-roberts opened this issue Jun 21, 2019 · 4 comments
Closed
Assignees

Comments

@a-roberts
Copy link
Member

Expected Behavior

package-lock.json should be adhered to

Actual Behavior

We suggest npm installing. We should suggest Node.js 10.x I believe and npm ci instead so our package-lock.json is taken into account.

@dibbles noticed bold font styling and a scrollbar on the delete dialog for the extension when using Node 12 with a newly generated package-lock.json as a result of npm installing

@a-roberts a-roberts changed the title Advocate for reusable builds on installing the dashboard Advocate for reproducible builds on installing the dashboard from source Jun 21, 2019
@mnuttall mnuttall changed the title Advocate for reproducible builds on installing the dashboard from source Developers should use npm ci when installing the dashboard from source Jul 1, 2019
@jessm12
Copy link
Member

jessm12 commented Jul 8, 2019

/assign

@jessm12
Copy link
Member

jessm12 commented Jul 8, 2019

PR: #317

@jessm12
Copy link
Member

jessm12 commented Jul 9, 2019

/close

@tekton-robot
Copy link
Contributor

@jessm12: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants