Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service monitors deployed by tektonInstallerSets have incorrect monitoring namespace #1595

Open
mustafaStakater opened this issue Jun 26, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mustafaStakater
Copy link

Expected Behavior

ServiceMonitor (monitoring.coreos.com/v1) installed in target namespace by TektonInstallerSets should have monitoringNamespace = targetNamespace.

Actual Behavior

The monitoring namespace in service monitor is openshift-pipelines rather than the target namespace specified in tektonConfig.

Steps to Reproduce the Problem

  1. Install the openshift-pipelines operator. Disable the default tektonconfig with AUTOINSTALL_COMPONENTS set to false
  2. Create the tektonconfig custom resource with targetNamespace set (different from openshift-pipelines)
  3. View the servicemonitors deployed in target namespace.

Screenshot

Screenshot from 2023-06-26 12-01-14

Additional Info

  • OpenShift version: 4.11.42
  • Kubernetes version: v1.24.12+ceaf338
  • Openshift Pipelines Operator version: v1.10.4
  • Tekton Pipelines version: v0.44.2
@mustafaStakater mustafaStakater added the kind/bug Categorizes issue or PR as related to a bug. label Jun 26, 2023
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants