Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruner: allow setting different "keep" and "keepSince" settings per namespace #1921

Open
wilstdu opened this issue Jan 3, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@wilstdu
Copy link

wilstdu commented Jan 3, 2024

Feature request

Allow setting different "keep" and "keepSince" pruner settings per namespace, because namespaces may have a different amount of traffic, so in some cases it makes sense to have a certain amount of PipelineRuns in the namespace (like the namespace has a lot of traffic, many PipelineRuns created daily/hourly), and there are cases when it makes more sense to use keepSince and delete by age (namespaces that have less traffic, would keep irrelevant (old) PipelineRuns until "keep" threshold is reached - doesn't make sense, because more PipelineRuns = slower tekton-controller). Even better would be to have an ability to combine both of these settings per namespace, but that's not yet possible because of Tekton CLI (tektoncd/cli#2206).

Use case

Tekton runs PipelineRuns in multiple, dynamically created namespaces, some namespaces get more traffic, others - less (for understanding: production and development branch namespace), this means that different namespaces may need different pruning options based on the workloads they run.

@wilstdu wilstdu added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 3, 2024
@tomalexander
Copy link

Is this possible using the namespace annotations? https://tekton.dev/docs/operator/tektonconfig/#pruner-namespace-annotations

@jkandasa
Copy link
Member

jkandasa commented Oct 2, 2024

@tomalexander yes, it is possible to use the namespace annotations. Please follow the document you have mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants