Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup PR testing for build-pipeline unit tests #15

Closed
bobcatfish opened this issue Sep 7, 2018 · 3 comments
Closed

Setup PR testing for build-pipeline unit tests #15

bobcatfish opened this issue Sep 7, 2018 · 3 comments

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Sep 7, 2018

Expected Behavior

Every PR should have unit tests run against it automatically.

(The long term dream is that we use the Pipeline CRD reference implementation itself to test this repo, but since it is just an API right now, that's a ways off!)

Actual Behavior

We have no automation! Is master broken? WHO KNOWS IT'S A CRAZY WORLD 🤠

Steps to Reproduce the Problem

  1. Open a PR with broken unit tests
  2. Notice that nothing catches this

To actually run the tests:

make test

(see also the DEVELOPMENT.md)

Additional Info

We would be fine with using something like Travis initially, but it would have to be enabled for the entire knative org, and since the rest of the org is using Prow, we can probably jump on that train.

Configuration for Prow for the other knative projects lives in https://github.com/knative/test-infra/tree/master/ci/prow

@bobcatfish
Copy link
Collaborator Author

Quick notes re. Prow setup:

Later on we'll want to add some testgrid config too probably but we don't need that right away.

Docs:

Folks who are great resources for questions, review etc. would be @adrcunha @cjwagner

@adrcunha
Copy link
Contributor

@aaron-prindle aaron-prindle moved this from To do to In progress in Pipeline CRD Sep 11, 2018
@aaron-prindle aaron-prindle self-assigned this Sep 11, 2018
@bobcatfish bobcatfish moved this from In progress to Done in Pipeline CRD Sep 17, 2018
@bobcatfish bobcatfish changed the title Setup CI for build-pipeline unit tests Setup PR testing for build-pipeline unit tests Sep 18, 2018
@bobcatfish
Copy link
Collaborator Author

Whoa i dunno how this stayed open so long, this was done ages ago :D

chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this issue Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Pipeline CRD
  
Done
Development

No branches or pull requests

3 participants