Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline Resources Redesign #1673

Closed
ghost opened this issue Dec 3, 2019 · 11 comments
Closed

Pipeline Resources Redesign #1673

ghost opened this issue Dec 3, 2019 · 11 comments
Assignees
@jerop
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ghost
Copy link

ghost commented Dec 3, 2019 •
edited by ghost
Loading

What is this thing?

This is a tracking issue / epic for all of the ongoing pipeline resources investigation, design and proof-of-concept work.

Existing Design Work and Feature Requests

Existing PipelineResource Problems

Design Docs Without A Home Anywhere Else
@ghost ghost added the Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) label Dec 3, 2019
@dibyom dibyom mentioned this issue Dec 3, 2019
Closed
@ghost ghost mentioned this issue Dec 5, 2019
Closed
@wlynch wlynch mentioned this issue Dec 9, 2019
Closed
@bobcatfish bobcatfish assigned bobcatfish and ghost Dec 19, 2019
This was referenced Dec 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@vdemeester vdemeester mentioned this issue Jan 22, 2020
Closed
@ghost ghost mentioned this issue Jan 22, 2020
Closed
3 tasks
@vdemeester vdemeester mentioned this issue Jan 30, 2020
Closed
@ghost
Copy link
Author

ghost commented Jan 30, 2020

PipelineResources have a big surface area so we've started to break the constituent pieces into their own deliverables. We've had good success and feedback so far as these features have been added. Workspaces and Task Results are two big chunks of work that support use cases we previously covered with PipelineResources.

As we pull these pieces into their own designs and implementations we're also thinking about how we could, in the future, package them all back up into something like PipelineResources that uses all these features but limits the configuration that users have to do. Certainly this won't happen before beta but we're still considering possibilities here.

@vdemeester vdemeester mentioned this issue Feb 10, 2020
Closed
This was referenced Feb 11, 2020
Closed
Closed
bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
@bobcatfish
Add Task equivlalent of PullRequest PipelineResource ⚗️
f9e2515 
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
@bobcatfish
Add Task equivlalent of PullRequest PipelineResource ⚗️
1d08dd7 
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
@bobcatfish bobcatfish mentioned this issue Mar 5, 2020
Merged
3 tasks
bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
@bobcatfish
Add Task equivlalent of PullRequest PipelineResource ⚗️
4e73645 
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
tekton-robot pushed a commit to tektoncd/catalog that referenced this issue Mar 6, 2020
@bobcatfish @tekton-robot
Add Task equivlalent of PullRequest PipelineResource ⚗️
dc6fb43 
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of #95
@bobcatfish bobcatfish mentioned this issue Apr 8, 2020
Closed
@bobcatfish bobcatfish mentioned this issue May 28, 2020
Closed
This was referenced Aug 12, 2020
Closed
Closed
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen
/reopen

@tekton-robot tekton-robot reopened this Aug 13, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 13, 2020
This was referenced Aug 14, 2020
Closed
Closed
Closed
@bobcatfish bobcatfish mentioned this issue Sep 1, 2020
Closed
@vdemeester vdemeester added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Sep 30, 2020
@ghost ghost mentioned this issue Oct 30, 2020
Closed
@bobcatfish bobcatfish assigned jerop and unassigned ghost Nov 3, 2020
@bobcatfish bobcatfish removed their assignment Nov 16, 2020
@vdemeester vdemeester mentioned this issue Nov 20, 2020
Closed
17 tasks
@bobcatfish bobcatfish mentioned this issue Jan 22, 2021
Merged
@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 17, 2021
@jerop jerop mentioned this issue Nov 15, 2021
Closed
@lbernick
Copy link
Member

lbernick commented May 5, 2022

@jerop @vdemeester @afrittoli @pritidesai should we keep this issue open? I think with TEP-0074 we know where we want to go with PipelineResources

@vdemeester
Copy link
Member

Yeah I think we can close 😇

@lbernick
Copy link
Member

lbernick commented May 6, 2022

/close

@tekton-robot
Copy link
Collaborator

@lbernick: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerop jerop

Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Pipelines V1
Status: Done
Tekton Pipelines Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vdemeester @bobcatfish @afrittoli @jerop @lbernick @tekton-robot