Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write our own helper image to stop sidecars #2560

Closed
imjasonh opened this issue May 6, 2020 · 3 comments
Closed

Write our own helper image to stop sidecars #2560

imjasonh opened this issue May 6, 2020 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@imjasonh
Copy link
Member

imjasonh commented May 6, 2020

Problem

Today, Tekton uses the tianon/true image to stop sidecar execution when steps complete. It's a small image that exits successfully immediately. We use it by updating sidecar containers' image to the true image, which stops the sidecar execution immediately (successfully).

This image isn't owned or maintained by the Tekton team, and though we expect it to be fairly stable and bug-free, we can't easily fix any bugs or add functionality if we decide we need to. It might also present licensing problems in some circumstances.

Proposal

Provide our own small Go binary in an image based on distroless to perform this functionality. For example, cmd/stop simply os.Exit(0)s immediately.

This image would be built and released using ko alongside all the other Tekton images.

If this seems reasonable, it should be a fairly #goodfirstissue for a potential new contributor.

@imjasonh imjasonh changed the title Write our own helper images to exit and copy Write our own helper image to stop sidecars May 6, 2020
@imjasonh
Copy link
Member Author

imjasonh commented May 6, 2020

Well don't I feel silly: #1510 😬

@vdemeester
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 6, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Jul 28, 2020

I think you just fixed this with #3025

@dlorenc dlorenc closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants