Remove cmd/nop #1510
Remove cmd/nop #1510
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
The raison d'être for this image was to be able to replace a running container with another image that would simply exit successfully, regardless of the user-defined args/env/etc. (since we can't update args, only the image name) Instead of building and providing our own image, we can simply use an image that contains only `true` as an entrypoint. `tianon/true` is such an image, which is _125 bytes_ in size. The image that's used is configurable by operators, the only requirement is that the image exit successfully regardless of provided inputs.
|
/lgtm |
|
neeeeeat /approve ( just wanna ping @vdemeester - wondering if there is any implication with using this image or if it's okay for folks integrating with tekton, since they can pass in another value for this if they need to?) |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests ❄️ |
|
/test pull-tekton-pipeline-integration-tests ❄️❄️ |
`nop` image is replaced by `tianon/true` see: tektoncd/pipeline#1510 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
The raison d'être for this image was to be able to replace a running
container with another image that would simply exit successfully,
regardless of the user-defined args/env/etc. (since we can't update
args, only the image name)
Instead of building and providing our own image, we can simply use an
image that contains only
trueas an entrypoint.tianon/trueis suchan image, which is 125 bytes in size.
The image that's used is configurable by operators, the only requirement
is that the image exit successfully regardless of provided inputs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes