Initial Implementation of conditionals #1093

dibyom · 2019-07-16T19:43:21Z

Changes

This commit adds an initial implementation for conditionals and depends on #1031.

In this implementation, condition evaluations aka ConditionChecks are
backed by TaskRuns. All conditionChecks associated with a PipelineTask
have to succeed before the task is executed. If a ConditionCheck fails,
the PipelineTask's associated TaskRun is marked failed i.e. its
Status.ConditionSucceeded is False. However, the PipelineRun itself
is not marked as failed.

Future PRs will add full support for passing in parameters, resource contents, and ability to read pipelinerun status from within the conditional container.

Part of #1019

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Release Notes

Adds a Condition type that can be used to conditionally execute tasks in a pipeline. Docs are in ./docs/condtions.md and ./docs/pipelines.md

tekton-robot · 2019-07-16T19:58:38Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/condition_validation.go	Do not exist	87.5%
pkg/reconciler/v1alpha1/pipelinerun/controller.go	Do not exist	100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	Do not exist	81.9%
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	100.0%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	80.6%	-3.4
test/controller.go	36.2%	34.6%	-1.6

bobcatfish · 2019-07-18T23:10:12Z

Pretty nice coverage boost! :D It looks like the coverage for test/builder/pipeline.go went down which I think means we are missing the test for what you've added to the builder (we do test the tests in this case XD). Would be nice to cover the additions to test/controller.go but that can be hard 😅

m1093782566 · 2019-07-21T12:33:18Z

Nice work!
/cc

tekton-robot · 2019-07-21T12:33:19Z

@m1093782566: GitHub didn't allow me to request PR reviews from the following users: m1093782566.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Nice work!
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobcatfish · 2019-07-22T11:32:17Z

@dibyom let me know if you want me to review this now - I'm assuming we want to resolve the whole TaskRun question from #1031 before getting too deep into this one.

tekton-robot · 2019-07-22T19:15:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/pipelinerun/controller.go	Do not exist	100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	Do not exist	81.9%
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

This commit refactors the labels, annotations, default timeouts, and service account fields from taskruns into helper functions. This will allow us to easily reuse some common defaults for regular taskruns as well as those created for conditionals in tektoncd#1093

tekton-robot · 2019-07-22T20:35:20Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/pipelinerun/controller.go	Do not exist	100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	Do not exist	81.9%
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

This commit refactors the labels, annotations, default timeouts, and service account fields from taskruns into helper functions. This will allow us to easily reuse some common defaults for regular taskruns as well as those created for conditionals in tektoncd#1093

This commit refactors the labels, annotations, default timeouts, and service account fields from taskruns into helper functions. This will allow us to easily reuse some common defaults for regular taskruns as well as those created for conditionals in tektoncd#1093 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

This commit refactors the labels, annotations, default timeouts, and service account fields from taskruns into helper functions. This will allow us to easily reuse some common defaults for regular taskruns as well as those created for conditionals in tektoncd#1093 Also, this replaces some of the TestReconcile_ funcs that were testing only the functionality in these new helper functions with their own dedicated unit tests Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

This commit refactors the labels, annotations, default timeouts, and service account fields from taskruns into helper functions. This will allow us to easily reuse some common defaults for regular taskruns as well as those created for conditionals in tektoncd#1093 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

tekton-robot · 2019-07-24T14:59:49Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/pipelinerun/controller.go	Do not exist	100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	Do not exist	81.9%
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

tekton-robot · 2019-07-29T15:55:35Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	74.2%	82.0%	7.8
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

tekton-robot · 2019-07-29T18:08:54Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	74.2%	82.0%	7.8
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

tekton-robot · 2019-07-29T18:37:20Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	74.2%	82.0%	7.8
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	84.0%	83.1%	-1.0
test/controller.go	36.2%	34.6%	-1.6

dibyom · 2019-07-29T19:04:27Z

/test pull-tekton-pipeline-build-tests

dibyom · 2019-07-29T19:12:49Z

/hold cancel

bobcatfish

Looking great! I think all of my comments are pretty minor things about docs or adding comments, generally looks like it's pretty much ready to go! 🎉 🎉 🎉

test/builder/pipeline.go

docs/conditions.md

docs/pipelines.md

bobcatfish · 2019-07-30T00:20:53Z

pkg/apis/pipeline/v1alpha1/condition_types_test.go

+	if !cc.IsSuccessful() {
+		t.Fatal("Expected conditionCheck status to be done")
+	}
+}


bobcatfish · 2019-07-30T00:21:28Z

pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go

+						c.Recorder.Eventf(pr, corev1.EventTypeWarning, "ConditionCheckCreationFailed", "Failed to create TaskRun %q: %v", rcc.ConditionCheckName, err)
+						return xerrors.Errorf("error creating ConditionCheck container called %s for PipelineTask %s from PipelineRun %s: %w", rcc.ConditionCheckName, rprt.PipelineTask.Name, pr.Name, err)
+					}
+				}


I'll play around with this some more, but what do you think about refactoring this in a follow-up?

Sounds good to me :D Thanks for looking into it :)

pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go

bobcatfish · 2019-07-30T00:26:36Z

pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go

+
+func (e *ConditionNotFoundError) Error() string {
+	return fmt.Sprintf("Couldn't retrieve Condition %q: %s", e.Name, e.Msg)
+}


ResolvePipelineRun definitely does a lot (e.g. resolving tasks, taskruns resources, and now conditions and checks). I'm open to ideas on simplifying/modularizing this. At the moment though, we need this in order to build the full PipelineRunState in one call which is then used by the reconciler.

kk maybe we can refactor it in follow up PRs! For me the most appealing option is to have multiple Resolve functions, each resolving a different type of thing, each being called by the Reconciler - then the Reconciler will know what kind of error message to set cuz it will know what kind of thing its trying to reconcile. Not super important tho!

bobcatfish · 2019-07-30T00:28:20Z

test/pipelinerun_test.go

@@ -113,6 +114,32 @@ func TestPipelineRun(t *testing.T) {
 		// 1 from PipelineRun and 1 from Tasks defined in pipelinerun
 		expectedNumberOfEvents: 2,
 		pipelineRunFunc:        getHelloWorldPipelineRun,
+	}, {
+		name: "pipeline succeeds when task skipped due to failed condition",


thanks for adding this! i think i derped a little bit when I suggested this be an end to end test vs. an example: i though the pipelinerun would end up failing (therefore wouldnt work as an example) but i forgot that a failing condition actually doesnt affect the success of the PipelineRun 🤦‍♀ anyway tho i think either is fine :D

Well, this led me down a rabbit hole which led to #1130 which I think was what finally fixed the issue where creating and using a Condition immediately would always fail with a NotFound error. So, definitely worth it 👼

tekton-robot · 2019-07-30T02:28:25Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	80.9%	82.3%	1.4
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	83.8%	82.8%	-1.0
test/controller.go	36.2%	34.6%	-1.6

tekton-robot · 2019-07-30T03:03:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	80.9%	82.3%	1.4
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	83.8%	82.8%	-1.0
test/controller.go	36.2%	34.6%	-1.6

tekton-robot · 2019-07-30T03:16:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	80.9%	82.3%	1.4
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	83.8%	86.1%	2.3
test/controller.go	36.2%	34.6%	-1.6

In this implementation, condition evaluations aka ConditionChecks are backed by TaskRuns. All conditionChecks associated with a `PipelineTask` have to succeed before the task is executed. If a ConditionCheck fails, the PipelineTask's associated TaskRun is marked failed i.e. its `Status.ConditionSucceeded` is False. However, the PipelineRun itself is not marked as failed. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

Instead of modifying the passed in pipelinerun's status, return the status to be updated. Also, updates the multiple status tests with conditionChecks to a single one with multiple inputs

tekton-robot · 2019-07-30T21:16:04Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	80.9%	82.3%	1.4
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	83.8%	86.1%	2.3
test/controller.go	36.2%	34.6%	-1.6

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

tekton-robot · 2019-07-30T21:38:02Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_types.go	0.0%	33.3%	33.3
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go	80.9%	82.3%	1.4
pkg/reconciler/v1alpha1/pipelinerun/resources/conditionresolution.go	Do not exist	76.7%
pkg/reconciler/v1alpha1/pipelinerun/resources/pipelinerunresolution.go	90.2%	90.5%	0.3
test/builder/pipeline.go	83.8%	86.1%	2.3
test/controller.go	36.2%	34.6%	-1.6

bobcatfish

This is looking great to me! Thanks for responding to everything @dibyom 🙏🙏🙏

/lgtm
/approve
/meow space

bobcatfish · 2019-07-30T23:14:18Z

docs/conditions.md

+
+This document defines `Conditions` and their capabilities.
+
+*NOTE*: This feature is currently a WIP being tracked in [#1137](https://github.com/tektoncd/pipeline/issues/1137)


bobcatfish · 2019-07-30T23:17:27Z

pkg/apis/pipeline/register.go

 	PipelineTaskLabelKey = "/pipelineTask"
+
+	// ConditionCheck is used as the label identifier for a ConditionCheck


thanks for adding these!!

tekton-robot · 2019-07-30T23:30:55Z

@bobcatfish:

In response to this:

This is looking great to me! Thanks for responding to everything @dibyom 🙏🙏🙏

/lgtm
/approve
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2019-07-30T23:30:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2019

tekton-robot requested a review from bobcatfish July 16, 2019 19:43

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 16, 2019

tekton-robot requested a review from vdemeester July 16, 2019 19:43

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 16, 2019

dibyom changed the title ~~Conditional init~~ Initial Implementation of conditionals Jul 16, 2019

dibyom force-pushed the conditional_init branch from 78b01d3 to 18cd784 Compare July 16, 2019 19:55

dibyom force-pushed the conditional_init branch from 18cd784 to e3959f0 Compare July 22, 2019 15:25

dibyom changed the title ~~Initial Implementation of conditionals~~ WIP: Initial Implementation of conditionals Jul 22, 2019

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2019

dibyom force-pushed the conditional_init branch 2 times, most recently from 3f316b0 to d519652 Compare July 22, 2019 19:11

dibyom mentioned this pull request Jul 22, 2019

Refactor some taskrun fields into helper functions #1110

Merged

1 task

dibyom force-pushed the conditional_init branch from a3fcbc9 to 30bc7a6 Compare July 24, 2019 14:56

dibyom changed the title ~~WIP: Initial Implementation of conditionals~~ Initial Implementation of conditionals Jul 24, 2019

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2019

dibyom force-pushed the conditional_init branch from 9b97042 to 3ccbe7e Compare July 29, 2019 18:06

dibyom force-pushed the conditional_init branch from 3ccbe7e to 981ca68 Compare July 29, 2019 18:34

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2019

bobcatfish reviewed Jul 30, 2019

View reviewed changes

dibyom force-pushed the conditional_init branch from 981ca68 to 7b206e8 Compare July 30, 2019 02:26

dibyom force-pushed the conditional_init branch from 7b206e8 to a364586 Compare July 30, 2019 02:59

dibyom force-pushed the conditional_init branch from a364586 to a4fa4f8 Compare July 30, 2019 03:14

dibyom added 2 commits July 30, 2019 17:11

Refactor updateTaskRunsStatus to getTaskRunsStatus

e33c7ad

Instead of modifying the passed in pipelinerun's status, return the status to be updated. Also, updates the multiple status tests with conditionChecks to a single one with multiple inputs

dibyom force-pushed the conditional_init branch from a4fa4f8 to d3dcb72 Compare July 30, 2019 21:13

Add intial skeleton docs for conditions

2742dde

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

dibyom force-pushed the conditional_init branch from d3dcb72 to 2742dde Compare July 30, 2019 21:35

bobcatfish reviewed Jul 30, 2019

View reviewed changes

tekton-robot assigned bobcatfish Jul 30, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019

tekton-robot merged commit f880ffa into tektoncd:master Jul 30, 2019

dibyom deleted the conditional_init branch July 31, 2019 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Implementation of conditionals #1093

Initial Implementation of conditionals #1093

dibyom commented Jul 16, 2019 •

edited

tekton-robot commented Jul 16, 2019

bobcatfish commented Jul 18, 2019

m1093782566 commented Jul 21, 2019

tekton-robot commented Jul 21, 2019

bobcatfish commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

tekton-robot commented Jul 24, 2019

tekton-robot commented Jul 29, 2019

tekton-robot commented Jul 29, 2019

tekton-robot commented Jul 29, 2019

dibyom commented Jul 29, 2019

dibyom commented Jul 29, 2019

bobcatfish left a comment

bobcatfish Jul 30, 2019

bobcatfish Jul 30, 2019

bobcatfish Jul 30, 2019

bobcatfish Jul 30, 2019

dibyom Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

bobcatfish left a comment

bobcatfish Jul 30, 2019

bobcatfish Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019


		This document defines `Conditions` and their capabilities.

		NOTE: This feature is currently a WIP being tracked in [#1137](https://github.com/tektoncd/pipeline/issues/1137)

		PipelineTaskLabelKey = "/pipelineTask"

		// ConditionCheck is used as the label identifier for a ConditionCheck

Initial Implementation of conditionals #1093

Initial Implementation of conditionals #1093

Conversation

dibyom commented Jul 16, 2019 • edited

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jul 16, 2019

bobcatfish commented Jul 18, 2019

m1093782566 commented Jul 21, 2019

tekton-robot commented Jul 21, 2019

bobcatfish commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

tekton-robot commented Jul 24, 2019

tekton-robot commented Jul 29, 2019

tekton-robot commented Jul 29, 2019

tekton-robot commented Jul 29, 2019

dibyom commented Jul 29, 2019

dibyom commented Jul 29, 2019

bobcatfish left a comment

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

dibyom Jul 30, 2019

Choose a reason for hiding this comment

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

bobcatfish left a comment

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

bobcatfish Jul 30, 2019

Choose a reason for hiding this comment

tekton-robot commented Jul 30, 2019

tekton-robot commented Jul 30, 2019

dibyom commented Jul 16, 2019 •

edited