Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/knative/pkg dependency and deps… #1117

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Bump github.com/knative/pkg dependency and deps… #1117

merged 3 commits into from
Jul 25, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 23, 2019 •
edited
Loading

Changes

… and update import path as it is now knative.dev/pkg (as all
knative projects)

It has to be done at some point 👼 I'll follow-up with PR in the other tekton repositories 👼

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 23, 2019
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2019
@vdemeester vdemeester force-pushed the bump-pkg branch 2 times, most recently from e8f5654 to b7fb048 Compare July 24, 2019 09:12
@vdemeester
Copy link
Member Author

Bumped kubernetes to 1.12.9 too
cc @tejal29

@tektoncd tektoncd deleted a comment from tekton-robot Jul 24, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/pipelinerun/cancel.go 100.0% 78.6% -21.4
pkg/reconciler/v1alpha1/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go Do not exist 79.6%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/pipelinerun/cancel.go 100.0% 78.6% -21.4
pkg/reconciler/v1alpha1/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go Do not exist 79.6%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/pipelinerun/cancel.go 100.0% 78.6% -21.4
pkg/reconciler/v1alpha1/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go Do not exist 79.6%

@afrittoli
Copy link
Member

This looks pretty straight forward - thanks for doing it! /lgtm

@bobcatfish
Copy link
Collaborator

( @afrittoli i think /lgtm has to be on its own line! and also recently it looked like if there was any text following it, e.g. "/lgtm i love cats" it wouldnt work either XD)

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@bobcatfish
Copy link
Collaborator

ruh roh

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/pipelinerun/cancel.go Do not exist 78.6%
pkg/reconciler/v1alpha1/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go Do not exist 79.6%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/pipelinerun/cancel.go Do not exist 78.6%
pkg/reconciler/v1alpha1/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go Do not exist 79.6%

@tejal29
Copy link
Contributor

tejal29 commented Jul 24, 2019

Thanks a bunch!!!

afrittoli
afrittoli approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Oh no... conflicting files :S

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Bump github.com/knative/pkg dependency and deps…
e6babc2 
… and update import path as it is now `knative.dev/pkg` (as all
knative projects)

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Bump kubernetes to 1.12.9
346a89c 
To follow what `knative.dev/*` have

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Fix gofmt on imports ordering
2384c1c 
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@abayer
Copy link
Contributor

abayer commented Jul 25, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@tekton-robot tekton-robot merged commit 42bc3fb into tektoncd:master Jul 25, 2019
@vdemeester vdemeester deleted the bump-pkg branch July 25, 2019 11:19
@marlon-gamez marlon-gamez mentioned this pull request Jul 29, 2019
Merged
vincent-pli added a commit to vincent-pli/triggers that referenced this pull request Aug 2, 2019
@vincent-pli
The knative/pkg import path changed to "knative.dev/pkg"
a45922c 
folow the tektoncd/pipeline#1117
- change the dependency path
- update the import path
@vincent-pli vincent-pli mentioned this pull request Aug 2, 2019
Merged
3 tasks
vincent-pli added a commit to vincent-pli/triggers that referenced this pull request Aug 2, 2019
@vincent-pli
The knative/pkg import path changed to "knative.dev/pkg"
d8b8971 
folow the tektoncd/pipeline#1117
- change the dependency path
- update the import path
tekton-robot pushed a commit to tektoncd/triggers that referenced this pull request Aug 6, 2019
@vincent-pli @tekton-robot
The knative/pkg import path changed to "knative.dev/pkg"
98fd16a 
folow the tektoncd/pipeline#1117
- change the dependency path
- update the import path
vdemeester pushed a commit to openshift/tektoncd-triggers that referenced this pull request Nov 7, 2019
@vincent-pli @tekton-robot
The knative/pkg import path changed to "knative.dev/pkg"
5fd3d1d 
folow the tektoncd/pipeline#1117
- change the dependency path
- update the import path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli approved these changes

@abayer abayer Awaiting requested review from abayer

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@abayer abayer

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vdemeester @tekton-robot @afrittoli @bobcatfish @tejal29 @abayer @googlebot