Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the dockerfile used to test image digest exports with Kaniko. #1141

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Switch the dockerfile used to test image digest exports with Kaniko. #1141

merged 1 commit into from
Jul 31, 2019

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 31, 2019

Changes

This dockerfile builds much faster than the other one, taking ~1s instead of a minute.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 31, 2019
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2019
@dlorenc
Switch the dockerfile used to test image digest exports with Kaniko.
e951e5b 
This dockerfile builds much faster than the other one, taking ~1s instead of a minute.
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 31, 2019

I noticed some recent flakes during integration test runs, and this test failed for me a few times locally with what looked like a timeout. I'm not convinced this fixes anything, but it can't hurt and will speed up e2e tests.

dibyom
dibyom approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 9d7e37e into tektoncd:master Jul 31, 2019
@dlorenc dlorenc deleted the kanikofast branch August 1, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@abayer abayer Awaiting requested review from abayer

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dlorenc @tekton-robot @dibyom @googlebot