Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the dockerfile used to test image digest exports with Kaniko. #1141

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Switch the dockerfile used to test image digest exports with Kaniko. #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/kaniko_task_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const (
func getGitResource(namespace string) *v1alpha1.PipelineResource {
return tb.PipelineResource(kanikoResourceName, namespace, tb.PipelineResourceSpec(
v1alpha1.PipelineResourceTypeGit,
tb.PipelineResourceSpecParam("Url", "https://github.com/pivotal-nader-ziada/gohelloworld"),
tb.PipelineResourceSpecParam("Url", "https://github.com/GoogleContainerTools/kaniko"),
))
}

Expand All @@ -56,7 +56,7 @@ func getTask(repo, namespace string, withSecretConfig bool) *v1alpha1.Task {
}
stepOps := []tb.ContainerOp{
tb.Args(
"--dockerfile=/workspace/gitsource/Dockerfile",
"--dockerfile=/workspace/gitsource/integration/dockerfiles/Dockerfile_test_label",
fmt.Sprintf("--destination=%s", repo),
"--context=/workspace/gitsource",
),
Expand Down Expand Up @@ -138,7 +138,7 @@ func TestKanikoTaskRun(t *testing.T) {
match := re.FindStringSubmatch(logs)
// make sure we found a match and it has the capture group
if len(match) != 2 {
t.Fatalf("Expected to find an image digest in the build output")
t.Fatalf("Expected to find an image digest in the build output: %s", logs)
}
// match the local digest, which is first capture group against the remote image
digest := match[1]
Expand Down