Automatically create named directories for each output resource in a … #1156
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
googlebot
added
the
cla: yes
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-pipeline-integration-tests |
|
The following is the coverage report on pkg/.
|
…TaskRun. TaskRuns are expected to place files related to an Output in a directory named for each Output. Right now, we expect Task authors to create this directory before placing files there. This is onerous and error-prone, so we should automatically create them. There are a few approaches to doing this: - a mkdir init container - a volume - a mkdir pod container I chose to use the final one, a mkdir pod container for consistency with Input resources. This is prepended to the Task steps.
|
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Thank you for this, it's really helpful!
I'm a bit worried that the number of containers created by Tekton is exploding - so we may need to create a way to separate in the YAML user-step containers from those generated by Tekton.
Perhaps in future we could have a pre-process and post-process container where to hooks any extra step needed by Tekton, so that it's more obvious which containers run user steps and which run pre/post processing steps?
|
/lgtm |
…TaskRun.
Changes
TaskRuns are expected to place files related to an Output in a directory named
for each Output. Right now, we expect Task authors to create this directory before
placing files there. This is onerous and error-prone, so we should automatically create
them.
There are a few approaches to doing this:
I chose to use the final one, a mkdir pod container for consistency with Input resources.
This is prepended to the Task steps.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes