Helpful error message when multiple volumes share name #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Task is not allowed to have multiple volumes that share a name. Prior to this commit the error message printed when a name collision occurred was "expected exactly one, got both: name" which doesn't describe the problem clearly. After this commit the error message is updated to 'multiple volumes with same name "foo"'. A test case has been added to exercise the new message.
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
The following is the coverage report on pkg/.
|
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Oct 9, 2019
Before this, if a user wanted to attach a Volume named "workspace" they'd get a confusing error message (tektoncd#1402). tektoncd#1404 improves the error message, but it would be nice to not have an error at all and just allow user-defined volumes named "workspace"
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Nov 15, 2019
Before this, if a user wanted to attach a Volume named "workspace" they'd get a confusing error message (tektoncd#1402). tektoncd#1404 improves the error message, but it would be nice to not have an error at all and just allow user-defined volumes named "workspace"
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Nov 15, 2019
Before this, if a user wanted to attach a Volume named "workspace" they'd get a confusing error message (tektoncd#1402). tektoncd#1404 improves the error message, but it would be nice to not have an error at all and just allow user-defined volumes named "workspace"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1402
Changes
A Task is not allowed to have multiple volumes that share a name. Prior to this commit the error message printed when a name collision occurred was "expected exactly one, got both: name" which doesn't describe the problem clearly.
After this commit the error message is updated to 'multiple volumes with
same name "foo"'. A test case has been added to exercise the new message.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes docs (if user facing)Release Notes