Tag published images

[adshmh]

Changes

To make it easier to identify the installed version of tekton pipeline,
built images are now individually tagged with the specified release.
Partly addresses #1232.

This PR uses ko to tag the built images. Unfortunatelty, ko does not
specify the image tag on the output (only specifies the digest).
Therefore, what remains to be done is either:
a) log an issue against ko to include the tags, or
b) manually process the output of ko and append tags

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[tekton-robot]

Hi @adshmh. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

/ok-to-test

[afrittoli]

Thank you for this.

Tags are already added today - see L199-212.

The tagging is done using the gcloud client, and I would love to move away from it, to make this task more portable. I would be happy to apply the tags using ko, but I don't think we can handle the regional tags with ko.

[afrittoli]

To be honest, since we do not create regional release files, I doubt the regional images are ever used by anyone. I wonder if we should just push the images to gcr.io (which is hosted in the US for now, according to docs) - and we could move the bit that pushes to different regions to an optional step / task which is only executed when the target registry is gcr.io.
@bobcatfish @vdemeester thoughts?

[vdemeester]

@afrittoli we could to the initial push with the tag to gcr.io using ko (so no gcloud), and do the replication with the gcloud binary separately (maybe in async pipeline/task even 😉)

[afrittoli]

@vdemeester that sounds good to me. @adshmh this patch as it is now pushes the tag twice to gcr.io. Could you please remove the gcloud one - leaving the regions. We can move the region bit to a separate task in a different PR.

[vdemeester]

@afrittoli let's get this one merged, I'll do a quick follow-up 😉

[adshmh]

Thank you for the reviews. I will submit another PR to remove the gcloud tagging.

[vdemeester]

@adshmh see #1536 😅

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment