-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kube client oidc authentication support for testing #1577
Conversation
Hi @zhangtbj. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @vdemeester , Pls review by using this one. Thanks! |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @zhangtbj
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Currently, the test client in Tekton test doesn't support Kubernetes cluster with oidc authentication.
I tried to run e2e test for my Tekton build, and I found the test can only use the kubeconfig which in
~/.kube/config
, and my kube cluster useoidc
for auth but the current Tekton client doesn't support that.I take a look the knative serving and eventing, their clients have the config for oidc:
https://github.com/knative/serving/blob/78995f561c50acb87c9f5d386e07dbb3c597aeeb/test/clients.go#L25
But tekton test client doesn't have that:
https://github.com/tektoncd/pipeline/blob/master/test/clients.go
Without this
oidc
package,all tests will fail like:So I follow what knative repo did in this PR:
1, Use
dep
to add oidc package:dep ensure -add k8s.io/client-go/plugin/pkg/client/auth/oidc
2, Add import in
test/init_test.go
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: