Align pull request resource and pullrequest-init #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
2 tasks
afrittoli
force-pushed
the
github_token
branch
from
16659a6
to
1a96960
Compare
tekton-robot
added
size/S
afrittoli
force-pushed
the
github_token
branch
from
1a96960
to
e1f88a9
Compare
|
/test pull-tekton-pipeline-integration-tests |
afrittoli
force-pushed
the
github_token
branch
from
e1f88a9
to
3f58897
Compare
The pullrequest-init module reads the token from GITHUB_TOKEN.
The pull request resources sets strings.ToUpper('githubToken'),
so credentials are not picked up.
The environment variable name and the pull request field name
do not need to be bound to each other, so keep the pull request
field name to 'githubToken' (do not break anyone) - keep the
pullrequest-init interface with GITHUB_TOKEN, in case someone
uses it outside of the resource, and pass the right env
variable to match what pullrequest-init expects.
afrittoli
force-pushed
the
github_token
branch
from
3f58897
to
3f0689d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
bobcatfish
reviewed
Nov 26, 2019
| githubTokenEnv = "githubToken" | ||
| prSource = "pr-source" | ||
| githubTokenField = "githubToken" | ||
| // nolint: gosec |
There was a problem hiding this comment.
what's this about? (might be worth a comment of its own)
There was a problem hiding this comment.
I can add a comment as a follow-up.
gosec thinks that we might be hardcoding credentials in there....
I1126 14:29:17.615] pkg/apis/pipeline/v1alpha1/pull_request_resource.go:30: G101: Potential hardcoded credentials (gosec)
I1126 14:29:17.647] githubTokenEnv = "GITHUB_TOKEN"
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pullrequest-init module reads the token from GITHUB_TOKEN.
The pull request resources sets strings.ToUpper('githubToken'),
so credentials are not picked up.
The environment variable name and the pull request field name
do not need to be bound to each other, so keep the pull request
field name to 'githubToken' (do not break anyone) - keep the
pullrequest-init interface with GITHUB_TOKEN, in case someone
uses it outside of the resource, and pass the right env
variable to match what pullrequest-init expects.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes