Move MakePod to pkg/pod and unexport things #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
imjasonh
commented
Nov 26, 2019
ghost
reviewed
Nov 26, 2019
|
/lgtm |
tekton-robot
added
approved
|
/lgtm |
This makes TaskRun->Pod translation more encapsulated in pkg/pod. This takes the number of exported symbols in pkg/pod from 22 to 14. At least 4 of those remaining can be unexported once PodStatus->TaskRunStatus conversion is also moved into pkg/pod, and some of the rest are only exported because taskrun_test.go references them.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next phase of #1605
This makes TaskRun->Pod translation more encapsulated in pkg/pod.
This takes the number of exported symbols in pkg/pod from 22 to 14. At
least 4 of those remaining can be unexported once
PodStatus->TaskRunStatus conversion is also moved into pkg/pod, and some
of the rest are only exported because taskrun_test.go references them.
This change also adds some doc comments, and missing copyright headers 👨⚖
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: