Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 #1894

vdemeester · 2020-01-17T16:40:43Z

Changes

This updates cmd/webhook/main.go to use latest knative/pkg code, most simplified

This also changes the following:

Add validating and mutating webhook definition in yaml (so it gets
registered before the webhook starts)
~~Rename the controller service/deployment from tekton-pipelines-controller to controller~~
~~Rename the webhook service/deployment from tekton-pipelines-webhook to webhook~~
Use pipeline.tekton.dev/release instead of tekton.dev/release ;
mainly to let other project use their own (trigger.tekton.dev/release).

/hold waiting for 0.10 to be out to get this merge

Also, this moves the min k8s server version to 1.15.x

Closes #1113

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Tekton Pipelines will now required a k8s cluster 1.15+ (Internal kubernetes dependency is bumped to 1.16)

vdemeester · 2020-01-17T16:45:33Z

/hold

mattmoor · 2020-01-27T15:08:21Z

cmd/webhook/main.go

+		// A function that infuses the context passed to Validate/SetDefaults with custom metadata.
+		func(ctx context.Context) context.Context {
+			// FIXME(vdemeester) uncomment that for auto-conversion
+			// return v1alpha2.WithUpgradeViaDefaulting(store.ToContext(ctx))


Conversion webhooks are imminent in knative/pkg btw cc @dprotaso

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester · 2020-01-29T14:17:48Z

pkg/reconciler/pipelinerun/metrics_test.go

@@ -101,7 +111,7 @@ func TestRecordPipelineRunDurationCount(t *testing.T) {
 			err = metrics.DurationAndCount(test.taskRun)
 			assertErrIsNil(err, "DurationAndCount recording recording got an error", t)
 			metricstest.CheckDistributionData(t, "pipelinerun_duration_seconds", test.expectedTags, 1, test.expectedDuration, test.expectedDuration)
-			metricstest.CheckCountData(t, "pipelinerun_count", test.expectedTags, test.expectedCount)
+			metricstest.CheckCountData(t, "pipelinerun_count", test.expectedCountTags, test.expectedCount)


@mattmoor @hrishin wasn't sure about this… I don't fully understand the behavior change there 😅

This was a while ago, but I think maybe done by @anniefu?

Hmm, I created the metricstest helper package a while ago, but didn't do this particular test change.

A cursory glance implies that someone added a new tag to the "pipelinerun_count" metric so it has a different set of metrics tags as the "pipelinerun_duration_seconds" metric now, which isn't a problem.

vdemeester · 2020-01-29T15:41:39Z

I think it's gonna be green 🎉 💚
@mattmoor if you have a little bit of time to review the changes 👼 😝

mattmoor · 2020-01-29T15:56:06Z

Have a parent/teacher thing now, but will TAL after. Thanks for doing this!!! 🙏👍

bobcatfish · 2020-01-29T16:13:09Z

Just double checking, but knative is also requiring 1.15 or greater now? I think the GKE default is still 1.13 but 1.15 is available 🤔

Anyway assuming that:
/lgtm

vdemeester · 2020-01-29T16:45:01Z

/retest

vdemeester · 2020-01-31T12:09:46Z

/hold cancel

This is way simpler to follow. This change the following: - Add validating and mutating webhook definition *in* yaml (so it gets registered before the webhook starts) - Rename the controller service/deployment from `tekton-pipelines-controller` to `controller` - Rename the webhook service/deployment from `tekton-pipelines-webhook` to `webhook` - Use `pipeline.tekton.dev/release` instead of `tekton.dev/release` ; mainly to let other project use their own (`trigger.tekton.dev/release`). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester · 2020-01-31T14:04:36Z

It is green 🎉 🕺

ghost · 2020-01-31T14:14:28Z

/approve

tekton-robot · 2020-01-31T14:14:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hrishin · 2020-02-03T07:36:19Z

/LGTM

bobcatfish · 2020-02-14T19:22:33Z

We should probably update some docs when we bump the k8s dependency also, e.g.:

bobcatfish · 2020-02-14T19:22:47Z

And the release notes too, ill add something

In tektoncd#1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15.

In #1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15.

mattmoor · 2020-02-15T16:30:35Z

It is probably useful to also formulate some guidance around how these versions are bumped. We recently went through this exercise, and I'm happy to share if it's something you think it'd be worth aligning on.

In tektoncd#1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15. This adds it to the README.md, to make sure user know it too. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

In #1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15. This adds it to the README.md, to make sure user know it too. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

In #1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15. This adds it to the README.md, to make sure user know it too. Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit cd981b9)

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 17, 2020

tekton-robot requested review from afrittoli and a user January 17, 2020 16:40

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 17, 2020

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020

This was referenced Jan 21, 2020

Make sure the webhook is always registered before allowing user to create resources #1113

Closed

Update version of knative.dev/pkg #1940

Closed

vdemeester force-pushed the bump-k8s branch 4 times, most recently from 9e48050 to b7ffda9 Compare January 27, 2020 11:24

vdemeester changed the title ~~Bump kubernetes to 1.16.5 and knative/pkg to release-0.11~~ Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 Jan 27, 2020

mattmoor reviewed Jan 27, 2020

View reviewed changes

vdemeester mentioned this pull request Jan 28, 2020

Add PipelineRun types to v1alpha2 🎋 #1955

Merged

3 tasks

vdemeester force-pushed the bump-k8s branch 2 times, most recently from 7b2ab24 to e00dbf3 Compare January 29, 2020 13:56

Bump k8s.io to 1.16.5 and knative/pkg to latest

9dc4d93

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester force-pushed the bump-k8s branch from e00dbf3 to 75c2bdc Compare January 29, 2020 14:03

vdemeester commented Jan 29, 2020

View reviewed changes

vdemeester force-pushed the bump-k8s branch 2 times, most recently from f117375 to f416057 Compare January 29, 2020 15:40

tekton-robot assigned bobcatfish Jan 29, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

vdemeester force-pushed the bump-k8s branch from f416057 to bc721b7 Compare January 29, 2020 16:23

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

vdemeester force-pushed the bump-k8s branch 2 times, most recently from 8f34f71 to 61a5a52 Compare January 31, 2020 12:08

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020

vdemeester force-pushed the bump-k8s branch 2 times, most recently from 6d9b378 to a365c27 Compare January 31, 2020 13:14

vdemeester force-pushed the bump-k8s branch from a365c27 to 22d314d Compare January 31, 2020 13:35

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020

tekton-robot assigned hrishin Feb 3, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020

tekton-robot merged commit af781bf into tektoncd:master Feb 3, 2020

vdemeester deleted the bump-k8s branch February 3, 2020 08:36

vdemeester mentioned this pull request Feb 4, 2020

webhook knative.dev/pkg/controller is spitting a lot of error message #1998

Closed

chmouel mentioned this pull request Feb 4, 2020

webhook controller has a lot of messages error messages about missing cacert knative/pkg#1047

Closed

bobcatfish added a commit to bobcatfish/pipeline that referenced this pull request Feb 14, 2020

Indicate minimum cluster version is now 1.15 🚓

9c15c25

In tektoncd#1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15.

bobcatfish mentioned this pull request Feb 14, 2020

Indicate minimum cluster version is now 1.15 🚓 #2052

Merged

2 tasks

tekton-robot pushed a commit that referenced this pull request Feb 14, 2020

Indicate minimum cluster version is now 1.15 🚓

17d8572

In #1894 we bumped our k8s dependencies such that a cluster must now be running at least 1.15.

vincent-pli mentioned this pull request Feb 17, 2020

Support dry-run in the admission webhook #1513

Closed

vdemeester mentioned this pull request Mar 10, 2020

Indicate minimum cluster version is now 1.15 🚗 #2203

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 #1894

Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 #1894

vdemeester commented Jan 17, 2020 •

edited by bobcatfish

Loading

vdemeester commented Jan 17, 2020

mattmoor Jan 27, 2020

vdemeester Jan 27, 2020

vdemeester Jan 29, 2020

mattmoor Jan 29, 2020

anniefu Jan 29, 2020

vdemeester commented Jan 29, 2020

mattmoor commented Jan 29, 2020

bobcatfish commented Jan 29, 2020

vdemeester commented Jan 29, 2020

vdemeester commented Jan 31, 2020

vdemeester commented Jan 31, 2020

ghost commented Jan 31, 2020

tekton-robot commented Jan 31, 2020

hrishin commented Feb 3, 2020

bobcatfish commented Feb 14, 2020

bobcatfish commented Feb 14, 2020

mattmoor commented Feb 15, 2020

Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 #1894

Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 #1894

Conversation

vdemeester commented Jan 17, 2020 • edited by bobcatfish Loading

Changes

Submitter Checklist

Reviewer Notes

Release Notes

vdemeester commented Jan 17, 2020

mattmoor Jan 27, 2020

Choose a reason for hiding this comment

vdemeester Jan 27, 2020

Choose a reason for hiding this comment

vdemeester Jan 29, 2020

Choose a reason for hiding this comment

mattmoor Jan 29, 2020

Choose a reason for hiding this comment

anniefu Jan 29, 2020

Choose a reason for hiding this comment

vdemeester commented Jan 29, 2020

mattmoor commented Jan 29, 2020

bobcatfish commented Jan 29, 2020

vdemeester commented Jan 29, 2020

vdemeester commented Jan 31, 2020

vdemeester commented Jan 31, 2020

ghost commented Jan 31, 2020

tekton-robot commented Jan 31, 2020

hrishin commented Feb 3, 2020

bobcatfish commented Feb 14, 2020

bobcatfish commented Feb 14, 2020

mattmoor commented Feb 15, 2020

vdemeester commented Jan 17, 2020 •

edited by bobcatfish

Loading