Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick v0.10.x] Fix release yaml for openshift install 🐸 #1963

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

vdemeester
Copy link
Member

Changes

Cherry-pick of #1959

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 28, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@vdemeester vdemeester changed the title Fix release yaml for openshift install 🐸 [cherry-pick 0.10.x] Fix release yaml for openshift install 🐸 Jan 28, 2020
@vdemeester vdemeester changed the title [cherry-pick 0.10.x] Fix release yaml for openshift install 🐸 [cherry-pick v0.10.x] Fix release yaml for openshift install 🐸 Jan 28, 2020
@dibyom
Copy link
Member

dibyom commented Jan 28, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@takirala
Copy link
Contributor

@vdemeester can you also cherry pick #1966 I would be grateful if this can be included in the next release

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit d7bed88 into tektoncd:release-v0.10.x Jan 29, 2020
@vdemeester vdemeester deleted the 1959-cherry-pick branch January 29, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants