-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MiniShift from install documentation 🛃 #2189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we want to indicated that pipeline master only support the current version of openshift + the next one?
docs/install.md
Outdated
|
||
* [Configuring artifact storage](#configuring-artifact-storage) to set up artifact storage for Tekton Pipelines. | ||
* [Customizing basic execution parameters](#customizing-basic-execution-parameters) if you need to customize your service account, timeout, or Pod template values. | ||
|
||
If you want to run OpenShift 4.x on your laptop (or desktop), you | ||
should take a look it [Red Hat CodeReady Containers](https://github.com/code-ready/crc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*at
This also updates link to target OpenShift 4.3 documentation as it is the lowest version supported (for release >= 0.11). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
c08a437
to
40effda
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
/lgtm
Changes
This also updates link to target OpenShift 4.3 documentation as it is
the lowest version supported (for release >= 0.11).
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes