Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Task workspaces marshalling #2200

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fixes Task workspaces marshalling #2200

merged 1 commit into from
Mar 10, 2020

Conversation

skaegi
Copy link
Contributor

@skaegi skaegi commented Mar 10, 2020 •
edited
Loading

Fixes #2199

Changes

Adds json struct tags to Task workspaces

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

@skaegi
Fixes Task workspaces marshalling
6fb5fc0 
Adds json struct tags to Task workspaces
Fixes #2199
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 10, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@vdemeester vdemeester added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 10, 2020
@vdemeester vdemeester added this to the Pipelines 0.11 🐱 milestone Mar 10, 2020
vdemeester
vdemeester approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@tekton-robot tekton-robot merged commit b3dd3e3 into tektoncd:master Mar 10, 2020
@ghost
Copy link

ghost commented Mar 10, 2020

🙏 thankyou!

@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines 0.11 🐱
Development

Successfully merging this pull request may close these issues.

Task Workspaces do not serialize to json correctly
4 participants
@skaegi @tekton-robot @vdemeester @googlebot