Add the git resource ref to the ResourceResult for git resources. #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
Could you add a bit of explanation around the intended purpose? Is it related to a specific bug or feature request? |
dlorenc
force-pushed
the
namegit
branch
2 times, most recently
from
a04f24b
to
715280b
Compare
This includes the full name of the git resource in the resource result for git resources. We pass this along in the environment variable already, this includes it back in the resource result so we can tie the commit sha and branch name in the result. Right now Task results contain the exact commit that was cloned from any git resource inputs, but the "resourceref" field is empty. That makes it hard to tell which repo was cloned after. In the case of multiple inputs, there is no way to tell which result corresponds to which.
Added some more to the commit message. I think this was something just overlooked, so halfway between a feature request and a bug. |
|
/test pull-tekton-pipeline-integration-tests |
dibyom
approved these changes
Mar 18, 2020
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This includes the full name of the git resource in the resource result for
git resources. We pass this along in the environment variable already, this
includes it back in the resource result so we can tie the commit sha and
branch name in the result.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes