Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Fix spelling errors #2498

Merged
merged 1 commit into from May 27, 2020
Merged

[master] Fix spelling errors #2498

merged 1 commit into from May 27, 2020

Conversation

mattmoor
Copy link
Member

Produced via:
github.com/client9/misspell
/assign ImJasonH vdemeester
/cc ImJasonH vdemeester

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2020 •
edited

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
@tekton-robot
Copy link
Collaborator

Hi @mattmoor. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@ghost
Copy link

ghost commented Apr 27, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Apr 27, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@vdemeester
Copy link
Member

@mattmoor you need to sign the cla 😛

@mattmoor mattmoor force-pushed the misspell-tektoncd-pipeline-rwt7n-pod-hvh94 branch from 205bd18 to d866a6f Compare April 28, 2020 14:04
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@mattmoor
Copy link
Member Author

you need to sign the cla

I don't sign CLAs, VMware does. 😉

I kicked the machine last week when this new bot got turned on, and it is working its way through the red tape 🤞

Glad to see you finally dropped the googlebot 😂

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2020
@afrittoli
Copy link
Member

Holding off lgtm until CLA is green

@mattmoor mattmoor force-pushed the misspell-tektoncd-pipeline-rwt7n-pod-hvh94 branch from d866a6f to 0fe2a31 Compare May 4, 2020 14:06
@mattmoor
Copy link
Member Author

mattmoor commented May 4, 2020

I pinged the ticket this morning 😞

@mattmoor mattmoor force-pushed the misspell-tektoncd-pipeline-rwt7n-pod-hvh94 branch 2 times, most recently from f3d966b to ba5a5c9 Compare May 18, 2020 14:02
@mattmoor mattmoor closed this May 19, 2020
@mattmoor mattmoor reopened this May 19, 2020
@mattmoor
Copy link
Member Author

With some luck the CLA stuff has been resolved. IDK how to poke this bot, so I'm going to wait for the force push tomorrow morning 🤞

@vdemeester
Copy link
Member

@mattmoor you might need to re-push 😅

@ghost
Copy link

ghost commented May 21, 2020

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 21, 2020
@mattmoor mattmoor force-pushed the misspell-tektoncd-pipeline-rwt7n-pod-hvh94 branch from ba5a5c9 to ef78e09 Compare May 21, 2020 14:09
@mattmoor
[master] Fix spelling errors
442c513 
Produced via:
  `github.com/client9/misspell`
/assign ImJasonH vdemeester
/cc ImJasonH vdemeester
@mattmoor mattmoor force-pushed the misspell-tektoncd-pipeline-rwt7n-pod-hvh94 branch from ef78e09 to 442c513 Compare May 22, 2020 14:12
@jlpettersson
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@tekton-robot tekton-robot merged commit 9fd0908 into tektoncd:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@jlpettersson jlpettersson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattmoor @tekton-robot @vdemeester @afrittoli @jlpettersson @imjasonh