Revert "Use a helper for setting the Succeeded condition on PipelineRun." #2783
Conversation
…un." PR tektoncd#2749 introduces helpers to set the completion time along with setting the Succeeded condition to Unknown, True or False. This is fine, however in combination with a previous issue, whereby we update the Succeeded condition to False in case of failure as soon as the first failure is encountered, this results in having the completion time set as soon as the first failure is encountered, which may not match the actual completion time of the pipeline run, in case other tasks were already running when the initial failure occurred. For v0.13.x we shall keep completion time and condition update separated. Next release will include this plus a fix to the original issue. This reverts commit 8ff3169.
tekton-robot
added
the
size/L
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
The following is the coverage report on the affected files.
|
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
|
thanks @afrittoli |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
PR #2749 introduces helpers to set the completion time along with
setting the Succeeded condition to Unknown, True or False.
This is fine, however in combination with a previous issue, whereby
we update the Succeeded condition to False in case of failure as soon
as the first failure is encountered, this results in having the
completion time set as soon as the first failure is encountered,
which may not match the actual completion time of the pipeline run,
in case other tasks were already running when the initial failure
occurred.
For v0.13.x we shall keep completion time and condition update
separated. Next release will include this plus a fix to the
original issue.
This reverts commit 8ff3169.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind bug