Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish setting up events for pipeline runs #2874

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Finish setting up events for pipeline runs #2874

merged 1 commit into from
Jun 30, 2020

Conversation

afrittoli
Copy link
Member

Changes

Add the start events for pipelineruns.
Cleanup a bit of dead code where an event was generated but it's not used anymore.

Partly addresses #2082
Extracted from #2545

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The pipeline run controller now emits a k8s event every time that a pipeline is started.

/kind feature
/cc @dibyom @vdemeester

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

afrittoli
afrittoli commented Jun 29, 2020
View reviewed changes
pkg/reconciler/pipelinerun/pipelinerun.go
@@ -407,12 +413,6 @@ func (c *Reconciler) reconcile(ctx context.Context, pr *v1beta1.PipelineRun) err
return controller.NewPermanentError(err)
}

if pipelineState.IsDone() && pr.IsDone() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr.IsDone() only becomes true when the completion time is set, which happens down below in L461-466.
This is never invoked, as it is also proved by the fact that we don't get a duplicate event for this case.
The timeout is released in ReconcileKind when isDone is true.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.2% 85.9% 0.7

@afrittoli afrittoli added this to the Pipelines v0.14 milestone Jun 29, 2020
vdemeester
vdemeester reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
dibyom
dibyom reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small subjective nit about the terminology below. Also, this functionality is tested with existing tests right?

docs/events.md Show resolved Hide resolved
@afrittoli
Copy link
Member Author

One small subjective nit about the terminology below. Also, this functionality is tested with existing tests right?

Heh, good point, I added a bunch of tests related to events in the original PR, not only for the started event for events in general. I will add them back in to this PR.

@afrittoli
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@afrittoli
Finish setting up events for pipeline runs
d3deb3e 
Add the start events for pipelineruns. Cleanup a bit of dead code
where an event was generated but it's not used anymore.
@afrittoli afrittoli force-pushed the issues/2082-pipelinerun-events-start branch from f9320d8 to d3deb3e Compare June 29, 2020 21:43
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2020
@afrittoli
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 29, 2020
afrittoli
afrittoli commented Jun 29, 2020
View reviewed changes
pkg/reconciler/pipelinerun/pipelinerun_test.go
@@ -102,7 +102,40 @@ func conditionCheckFromTaskRun(tr *v1beta1.TaskRun) *v1beta1.ConditionCheck {
return &cc
}

func checkEvents(fr *record.FakeRecorder, testName string, wantEvents []string) error {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this very same approach for event testing in the taskrun controller.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.2% 85.9% 0.7

@afrittoli
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2020
vdemeester
vdemeester reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@tekton-robot tekton-robot merged commit c7a60b8 into tektoncd:master Jun 30, 2020
@pritidesai pritidesai mentioned this pull request Jun 30, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@pritidesai pritidesai pritidesai left review comments

@dibyom dibyom dibyom approved these changes

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@afrittoli @tekton-robot @vdemeester @pritidesai @dibyom