fix(substition): fix configmap and secret volume param substition

[FogDong]

Changes

fix(substition): fix configmap and secret volume param substition

Fix #3070

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

 fix(substition): fix configmap and secret volume param substition

[tekton-robot]

Hi @FogDong. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ghost]

/kind feature
/ok-to-test

[ghost]

This is great, thanks! Could you also update docs/variables.md to include these new entries? We have the following already:

| `Task` | `spec.volumes[].configmap.name` |
| `Task` | `spec.volumes[].secret.secretname` |

So I suggest also adding this:

| `Task` | `spec.volumes[].configmap.items[].key |
| `Task` | `spec.volumes[].configmap.items[].path |
| `Task` | `spec.volumes[].secret.items[].key |
| `Task` | `spec.volumes[].secret.items[].path |

[ghost]

Looks like extra spaces causing the build errors:

=============================
==== RUNNING BUILD TESTS ====
=============================
-------------------------------------------
---- Checking go code style with gofmt ----
-------------------------------------------
diff -u pkg/reconciler/taskrun/resources/apply_test.go.orig pkg/reconciler/taskrun/resources/apply_test.go
--- pkg/reconciler/taskrun/resources/apply_test.go.orig	2020-08-07 14:14:29.678540289 +0000
+++ pkg/reconciler/taskrun/resources/apply_test.go	2020-08-07 14:14:29.679540367 +0000
@@ -144,7 +144,7 @@
 						Name: "$(inputs.params.FOO)",
 					},
 					Items: []corev1.KeyToPath{{
-						Key: "$(inputs.params.FOO)",
+						Key:  "$(inputs.params.FOO)",
 						Path: "$(inputs.params.FOO)",
 					}},
 				},
@@ -155,7 +155,7 @@
 				Secret: &corev1.SecretVolumeSource{
 					SecretName: "$(inputs.params.FOO)",
 					Items: []corev1.KeyToPath{{
-						Key: "$(inputs.params.FOO)",
+						Key:  "$(inputs.params.FOO)",
 						Path: "$(inputs.params.FOO)",
 					}},
 				},

[FogDong]

@sbwsg Thank you for ur help ❤! Still not able to open the detail page because of the bad network...😭

[FogDong]

Well I guess I have to fix the build check tomorrow, the network problem is killing me 😑

[FogDong]

/retest

[FogDong]

PTAL @sbwsg 😉

[vdemeester]

/lgtm
/meow

[tekton-robot]

@vdemeester:

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment