Add variable expansion for ImagePullPolicy in Tasks. See #3423

[rinckm]

Changes

Add variable expansion in Tasks for fields:

• spec.steps[].imagePullPolicy
• spec.sidecar[].imagePullPolicy

Closes #3423

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Add variable expansion in Tasks for fields:
- `spec.steps[].imagePullPolicy`
- `spec.sidecar[].imagePullPolicy`

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Matthias Rinck (3a5839b)

[tekton-robot]

Hi @rinckm. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

Apologies for being late to the party but I'm a bit confused about why we need this - gonna go over to #3423 and comment there

[bobcatfish]

Thanks for answering my questions over in #3423! Meanwhile in this PR my only thought is I wonder if it would make sense to include an example, or end to end test (e.g. add the expansion to an existing test in https://github.com/tektoncd/pipeline/tree/master/test or add a new test) or to a "reconciler" test (e.g. it looks like the test at

pipeline/pkg/reconciler/taskrun/taskrun_test.go

Line 1089 in 05d67e4

name: "params",

is trying to make sure some other variables are replaced) to be sure the value is plumbed all the way through?

nbd tho if that feels like overkill!

/ok-to-test

[rinckm]

• ❌ Matthias Rinck The commit (801ab3c) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

I was added to the contributors list now. Can you please retrigger this check.

[rinckm]

Example added: examples/v1beta1/taskruns/image-params.yaml

[rinckm]

/test pull-tekton-pipeline-integration-tests

[ghost]

I just pulled down this branch to check what happens when an invalid imagePullPolicy is injected in this way from a param to the pod field. The TaskRun failed when creating the pod:

NAME                 SUCCEEDED   REASON           STARTTIME   COMPLETIONTIME
image-params-fqhmk   False       CouldntGetTask   86s

👍 thanks @rinckm . Are you working on the EasyCLA authorization on your side?

/approve

[rinckm]

👍 thanks @rinckm . Are you working on the EasyCLA authorization on your side?

Yes, hope I'll get this done in the next days.

[rinckm]

Force CLA check

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment