Updates to the HA document #3599
Conversation
tekton-robot
added
kind/documentation
tekton-robot
added
size/XS
|
Hi @qu1queee. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afrittoli fyi |
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
@qu1queee it looks like you dropped the release part from the PR template, I added it back with no release notes, feel free to change it if you want to provide release notes |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
|
@afrittoli thanks, I did add a sentence for the release notes. |
There was a problem hiding this comment.
@qu1queee could you please squash your commits? we want to have 1 commit per PR as described in https://github.com/tektoncd/community/blob/master/standards.md#commits
This document was missing the `data.buckets` configurable parameter for the leader election. Remove references to `data.resourceLock` for HA config While enhancing the HA document, we realized that the `resourceLock`` field is not configurable in the Knative side, but rather hardcoded. You can see in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L74-L87 , where the Config object is defined, that this field is not included. Also, the value for it seems to be hardcoded to "leases", as seen in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L38 Signed-off-by: Zoe <xigxjn@cn.ibm.com>
|
@jerop make sense, done |
|
/lgtm |
Changes
Enhance enabling-ha.md doc
data.bucketsconfigurable parameter for the leader election.Remove references to
data.resourceLockfor HA configresourceLockfield is not configurable in the Knative side, but rather hardcoded. You can see in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L74-L87, where the Config object is defined, that this field is not included. Also, the value for it seems to be hardcoded to "leases", as seen in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L38
In addition, categorize the changes you're making using the "/kind" Prow command, example:
/kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes