Bump knative to release-0.20 #3605

vdemeester · 2020-12-07T10:04:02Z

Changes

Bump knative to 0.20.

This also fix controller flag handling 🙃 (#3663, maybe others) :

Do not call flag.Parse() as it happens in
sharedmain.ParseAndGetConfigOrDie. Move anything that needs the flag
value after that call.

This also does something with QPS and Burst flag are they are already
defined in knative/pkg but with different default.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Updating knative.dev/pkg to release-0.20. This bumps the minimum supported version of kuberenetes to 0.17

vdemeester · 2020-12-07T10:04:33Z

/cc @tektoncd/core-maintainers

vdemeester · 2020-12-07T13:34:45Z

Note that this bump the minimum required k8s to 1.17 (https://github.com/knative/pkg/blob/release-0.19/version/version.go)

/hold

vdemeester · 2020-12-07T13:40:58Z

Also note that the integration test fails because of this min version, because the GKE version is v1.17.14-gke.400, which is a similar problem than #3335 (comment).

/cc @mattmoor

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester · 2021-01-07T14:39:06Z

This most likely fixes #3663 too 🙃

vdemeester · 2021-01-07T14:39:23Z

cc @zhouhaibing089

Do not call flag.Parse() as it happens in `sharedmain.ParseAndGetConfigOrDie`. Move anything that needs the flag value after that call. This also does something with QPS and Burst flag are they are already defined in knative/pkg *but* with different default. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester · 2021-01-07T14:44:52Z

/hold cancel

vdemeester · 2021-01-07T14:46:30Z

cmd/controller/main.go

+	if cfg.QPS == 0 {
+		cfg.QPS = 2 * rest.DefaultQPS
+	}
+	if cfg.Burst == 0 {
+		cfg.Burst = rest.DefaultBurst
+	}
+	// FIXME(vdemeester): this is here to not break current behavior
 	// multiply by 2, no of controllers being created
-	cfg.QPS = 2 * float32(*qps)
-	cfg.Burst = 2 * *burst
+	cfg.QPS = 2 * cfg.QPS
+	cfg.Burst = 2 * cfg.Burst


@tektoncd/core-maintainers This is a bit weird but it's there to keep the same behavior as of today. Because the flag default value is defined in knative/pkg, we don't have the control over it, so we detect if the default value are passed or not. The 2 * … I am not sure about why we are doing this, but I didn't want to change the behavior here.

bobcatfish · 2021-01-07T14:48:21Z

This also fix controller flag handling 🙃

@vdemeester what flag handling does this fix?

vdemeester · 2021-01-07T15:01:02Z

This also fix controller flag handling upside_down_face

@vdemeester what flag handling does this fix?

I linked the issue in comments. We do call flag.Parse before calling cfg := sharedmain.ParseAndGetConfigOrDie() which also does flag.Parse. The problem with that is… any new flag defined in knative/pkg are not parsed because we already parsed the flags before, thus, as #3663, some flags defined in knative are not handled correctly.

afrittoli

Thank you for this! Let's try and get this into v0.20.0
/approve

tekton-robot · 2021-01-07T15:47:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

afrittoli · 2021-01-07T15:48:03Z

/test check-pr-has-kind-label

afrittoli · 2021-01-07T16:27:38Z

/kind check-pr-has-kind-label

zhouhaibing089 · 2021-01-07T17:12:37Z

@vdemeester: Thanks for fixing the flag issue. :)

mattmoor · 2021-01-08T15:37:52Z

pkg/reconciler/pipelinerun/pipelinerun_test.go

@@ -142,7 +142,7 @@ func getPipelineRunController(t *testing.T, d test.Data) (test.Assets, func()) {
 	ctx, cancel := context.WithCancel(ctx)
 	ensureConfigurationConfigMapsExist(&d)
 	c, informers := test.SeedTestData(t, ctx, d)
-	configMapWatcher := configmap.NewInformedWatcher(c.Kube, system.GetNamespace())
+	configMapWatcher := cminformer.NewInformedWatcher(c.Kube, system.GetNamespace())


The point of this split btw was to enable you to write tests like this for your tiny containers:
https://github.com/mattmoor/mink/blob/master/cmd/extract-digest/depcheck_test.go#L27

Not necessary for this change, but we should follow up to add checks for all the containers that should be nice and tiny.

mattmoor

/lgtm

mattmoor · 2021-01-08T16:22:46Z

Registry 503:

Error reading blob sha256:c71a6f8e13782fed125f2247931c3eb20cc0e6428a5d79edb546f1f1405f0e49: invalid status code from registry 503 (Service Unavailable)

/retest

mattmoor · 2021-01-08T16:53:27Z

Looks like it maybe timing related:

message: TaskRun "workspace-in-sidecar-7ssh4" failed to finish within "1m0s"

I don't see anything else obvious in the logs, but y'all don't seem to describe the pods, which is generally pretty useful.

/retest

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Dec 7, 2020

tekton-robot requested review from dlorenc and a user December 7, 2020 10:04

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 7, 2020

tekton-robot requested a review from a team December 7, 2020 10:04

vdemeester force-pushed the bump-knative branch 2 times, most recently from a5bfcb2 to e795a6a Compare December 7, 2020 10:50

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020

vdemeester mentioned this pull request Dec 7, 2020

Tekton controller goes in crashloopbackoff in EKS #3335

Closed

tekton-robot requested a review from mattmoor December 7, 2020 13:40

vdemeester added this to the Pipelines v0.20 milestone Dec 8, 2020

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2020

vdemeester force-pushed the bump-knative branch from e795a6a to 7da84a2 Compare January 7, 2021 10:15

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

vdemeester changed the title ~~Bump knative to release-0.19~~ Bump knative to release-0.20 Jan 7, 2021

vdemeester force-pushed the bump-knative branch from 7da84a2 to fafc0f4 Compare January 7, 2021 10:19

Bump knative to release-0.20

882a4a7

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester force-pushed the bump-knative branch from fafc0f4 to 882a4a7 Compare January 7, 2021 10:49

vdemeester force-pushed the bump-knative branch from 93f1bc5 to 87b1059 Compare January 7, 2021 14:39

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021

vdemeester commented Jan 7, 2021

View reviewed changes

afrittoli reviewed Jan 7, 2021

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021

vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jan 8, 2021

mattmoor reviewed Jan 8, 2021

View reviewed changes

tekton-robot assigned mattmoor Jan 8, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021

mattmoor mentioned this pull request Jan 8, 2021

Update Deps mattmoor/mink#409

Merged

tekton-robot merged commit f121db9 into tektoncd:master Jan 8, 2021

vdemeester deleted the bump-knative branch January 8, 2021 17:27

zhouhaibing089 mentioned this pull request Jan 11, 2021

controller cann't run with --kubeconfig flag #3663

Closed

jerop mentioned this pull request Mar 2, 2021

Pipelines v0.20+ release broken for Kubernetes v1.16.x #3803

Closed

ghost mentioned this pull request Aug 11, 2021

Try reducing "Invalid log format" errors #4142

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump knative to release-0.20 #3605

Bump knative to release-0.20 #3605

vdemeester commented Dec 7, 2020 •

edited

Loading

vdemeester commented Dec 7, 2020

vdemeester commented Dec 7, 2020 •

edited

Loading

vdemeester commented Dec 7, 2020

vdemeester commented Jan 7, 2021

vdemeester commented Jan 7, 2021

vdemeester commented Jan 7, 2021

vdemeester Jan 7, 2021

bobcatfish commented Jan 7, 2021

vdemeester commented Jan 7, 2021

afrittoli left a comment

tekton-robot commented Jan 7, 2021

afrittoli commented Jan 7, 2021

afrittoli commented Jan 7, 2021

zhouhaibing089 commented Jan 7, 2021

mattmoor Jan 8, 2021

mattmoor left a comment

mattmoor commented Jan 8, 2021

mattmoor commented Jan 8, 2021

Bump knative to release-0.20 #3605

Bump knative to release-0.20 #3605

Conversation

vdemeester commented Dec 7, 2020 • edited Loading

Changes

Submitter Checklist

Reviewer Notes

Release Notes

vdemeester commented Dec 7, 2020

vdemeester commented Dec 7, 2020 • edited Loading

vdemeester commented Dec 7, 2020

vdemeester commented Jan 7, 2021

vdemeester commented Jan 7, 2021

vdemeester commented Jan 7, 2021

vdemeester Jan 7, 2021

Choose a reason for hiding this comment

bobcatfish commented Jan 7, 2021

vdemeester commented Jan 7, 2021

afrittoli left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 7, 2021

afrittoli commented Jan 7, 2021

afrittoli commented Jan 7, 2021

zhouhaibing089 commented Jan 7, 2021

mattmoor Jan 8, 2021

Choose a reason for hiding this comment

mattmoor left a comment

Choose a reason for hiding this comment

mattmoor commented Jan 8, 2021

mattmoor commented Jan 8, 2021

vdemeester commented Dec 7, 2020 •

edited

Loading

vdemeester commented Dec 7, 2020 •

edited

Loading