-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Add a "dropNetworking" function and unit tests to the… #3616
Conversation
… runner package."" This fixes the size calculation to also work on 32-bit systems. This can be quickly checked with "GOOS=linux GOARCH=arm go build ./..." The two commits can be seen separately here: tektoncd/pipeline@master...dlorenc:rollbacknet This reverts commit dccd0ed.
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bobcatfish we could use |
Here you go @bobcatfish #3621 |
… runner package.""
Changes
This fixes the size calculation to also work on 32-bit systems. This can be quickly
checked with "GOOS=linux GOARCH=arm go build ./..."
The two commits can be seen separately here: master...dlorenc:rollbacknet
This reverts commit dccd0ed.
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes