Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton Pipelines Topical Ownership #3662

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jan 6, 2021

Changes

We identified topic areas in Tekton Pipelines and established explicit
ownership on specific areas of the codebase in doc

Topical owners are responsible for triaging bugs, reviewing TEPs and
moving along any work in their topic areas

Next step would be automating tagging topical owners on issues, PRs
and TEPs on their topic areas

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jan 6, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2021
@jerop jerop marked this pull request as ready for review January 6, 2021 20:53
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2021
topical-ownership.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@vdemeester
Copy link
Member

Question, do we also want to add some OWNERS file in some packages ? (note that can be done in follow-ups)

We identified topic areas in Tekton Pipelines and established explicit
ownership on specific areas of the codebase in https://docs.google.com/document/d/1k4ZDcdpfjq_LUxR2D3Ka16kvtZMCd1moZCgFqnCaq4w/edit

Topical owners are responsible for triaging bugs, reviewing TEPs and
moving along any work in their topic areas
@jerop
Copy link
Member Author

jerop commented Jan 12, 2021

Question, do we also want to add some OWNERS file in some packages ? (note that can be done in follow-ups)

sure, will add that to the next steps

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit a4fbc7d into tektoncd:master Jan 12, 2021
@jerop jerop deleted the topical-ownership branch June 11, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants